Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wikipedia title should use titles.Normalized instead of titles.Display #106

Closed
pajlada opened this issue Mar 21, 2021 · 0 comments · Fixed by #118
Closed

Wikipedia title should use titles.Normalized instead of titles.Display #106

pajlada opened this issue Mar 21, 2021 · 0 comments · Fixed by #118

Comments

@pajlada
Copy link
Member

pajlada commented Mar 21, 2021

When querying the Wikipedia page summary API for an article we get 3 different title keys:
canonical, normalized, and display.
we currently use display, which seems fine for most cases but for pages like https://en.wikipedia.org/wiki/Test_(2013_film) with Display we get the italized version which shows up as Test in the tooltip right now.

We should probably move to the "normalized" key instead
pajlada added a commit that referenced this issue Apr 11, 2021
@pajlada
Use Normalized title instead of Display title from Wikipedia API
1ac83a8 
Fixes #106
@pajlada pajlada mentioned this issue Apr 11, 2021
Merged
1 task
pajlada added a commit that referenced this issue Apr 11, 2021
@pajlada
Use Normalized title instead of Display title from Wikipedia API (#118)
e08d077 
* Use Normalized title instead of Display title from Wikipedia API

Fixes #106

* Update changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Normalized title instead of Display title from Wikipedia API Chatterino/api
1 participant
@pajlada