Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass http.Request to load functions in custom resolvers #165

Closed
zneix opened this issue Jun 11, 2021 · 0 comments · Fixed by #167
Closed

Pass http.Request to load functions in custom resolvers #165

zneix opened this issue Jun 11, 2021 · 0 comments · Fixed by #167

Comments

@zneix
Copy link
Collaborator

zneix commented Jun 11, 2021

This would be necessary for proxying thumbnails in custom resolvers, because utils.FormatThumbnailURL takes *http.Request as an argument, however it is a nil in that scope, making it impossible to call that method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass http.Request all the way to custom resolver load functions Chatterino/api
1 participant
@zneix