Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block private network requests #480

Open
pajlada opened this issue May 25, 2023 · 1 comment
Open

Block private network requests #480

pajlada opened this issue May 25, 2023 · 1 comment

Comments

@pajlada
Copy link
Member

pajlada commented May 25, 2023

Currently, the API can make requests to the local network (e.g. 192.168.0.1)

We should block this

See https://datatracker.ietf.org/doc/html/rfc1918

Specifically

10.0.0.0        -   10.255.255.255  (10/8 prefix)
172.16.0.0      -   172.31.255.255  (172.16/12 prefix)
192.168.0.0     -   192.168.255.255 (192.168/16 prefix)
@pajlada
Copy link
Member Author

pajlada commented Sep 13, 2023

Direct requests (e.g. https://192.168.0.1) no longer load as of #529 - there's some additional progress to make sure domains like https://192.168.0.1.nip.io don't load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant