Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure format on CI and fix unformatted files #43

Merged
merged 4 commits into from
Oct 7, 2020
Merged

Ensure format on CI and fix unformatted files #43

merged 4 commits into from
Oct 7, 2020
+126 −118

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Sep 18, 2020

No description provided.

@exoego exoego changed the title Enforce format Check format on CI and fix unformatted files Sep 18, 2020
@exoego exoego marked this pull request as draft September 18, 2020 02:58
@exoego exoego force-pushed the ci-scalafmt branch 2 times, most recently from 32c02b1 to fc9ee29 Compare October 7, 2020 01:48
@exoego exoego changed the title Check format on CI and fix unformatted files Ensure format on CI and fix unformatted files Oct 7, 2020
@exoego exoego marked this pull request as ready for review October 7, 2020 01:56
hayasshi
hayasshi suggested changes Oct 7, 2020
View reviewed changes
.circleci/config.yml Outdated
sbt clean ++"2.12.10" test
sbt clean ++"2.13.1" test
sbt clean ++"2.12.10" scalafmtCheckAll scalafmtSbt test
sbt clean ++"2.13.1" scalafmtCheckAll scalafmtSbt test
Copy link
Contributor

@hayasshi hayasshi Oct 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exoego
Do you want to set scalafmtSbtCheck?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Fixed in de1c85c

@exoego exoego merged commit 51de3f5 into master Oct 7, 2020
@exoego exoego deleted the ci-scalafmt branch October 7, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayasshi hayasshi hayasshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exoego @hayasshi