Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify license acquisition succeeded #4

Closed
chbrown opened this issue Aug 13, 2018 · 4 comments
Closed

Verify license acquisition succeeded #4

chbrown opened this issue Aug 13, 2018 · 4 comments
Assignees

Comments

@chbrown
Copy link
Owner

chbrown commented Aug 13, 2018

Either by checking the file contents or the result of the curl call in acquire_license.

(Debugging upstream errors requires a tedious extra step if the license fails; see #3)

@chbrown chbrown self-assigned this Aug 13, 2018
@chbrown
Copy link
Owner Author

chbrown commented Jan 12, 2021

See also #30 — still an issue.

Failure at this stage should display clear instructions on how to resolve the issue, which AFAICT simply consists of trashing the original ODM along with any derivative files generated so far, and retrying with a freshly downloaded ODM.

@oranges13
Copy link

This is still an issue and I would agree that instructions on how to resolve this (delete / redownload) would be appreciated.

@chbrown
Copy link
Owner Author

chbrown commented Jan 1, 2022

Btw. 25a3e94 is intended to address this.

@chbrown
Copy link
Owner Author

chbrown commented Jan 2, 2022

...also ab1dfcc.

Ideally, curl would have some combination of flags like --fail --output success.txt --fail-output - that would switch output destination on HTTP error codes, so that the failure response could be written to stdout (or wherever). But AFAICT if I want to handle response data differently based on the HTTP status code, I would have to 1) write the output to a temporary file, 2) parse out the status code, 3) on failure, just cat the temp file and exit 1, 4) on success, parse out the response body (remove the status line and headers) and write it to the (ODM-adjacent) license file. Which seems like an awful lot of extra work/complexity for what should be a pretty rare failure 😬

Closing this since 25a3e94 and ab1dfcc should now make recovery easier, but if anyone stumbles on this in the future, feel free to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants