Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all the events #1

Closed
chc4 opened this issue Nov 22, 2014 · 2 comments
Closed

Add all the events #1

chc4 opened this issue Nov 22, 2014 · 2 comments

Comments

@chc4
Copy link
Owner

chc4 commented Nov 22, 2014

XServer::get_event should handle most(if not all) of the event types.
It should also wrap the important/relevant members of the event into an enum it returns. Also, fix your naming - match on a ButtonPress, cast to XButtonPressedEvent, and return a ButtonPressed? That's terrible.

@chc4
Copy link
Owner Author

chc4 commented Jan 8, 2015

With Enum variants being namespaced now, the ServerEvent variants are named the same as the XEvent ones (just with extra information for a match to act on)

@chc4
Copy link
Owner Author

chc4 commented Oct 15, 2015

This is pretty much just a duplicate of #3 now.

@chc4 chc4 closed this as completed Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant