Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor dir and use go.mod directly #67

Closed
snprajwal opened this issue Jun 2, 2022 · 2 comments · Fixed by #68
Closed

Remove vendor dir and use go.mod directly #67

snprajwal opened this issue Jun 2, 2022 · 2 comments · Fixed by #68

Comments

@snprajwal
Copy link
Member

This issue is being opened to discuss the possibility of removing the vendor dir from the repo. Vendoring enables us to have reproducible builds, but at the cost of updates and security fixes in newer versions of the modules.

Including the upcoming crit library, we will be using three modules - proto, x/sys and protojson. All three are hardened packages with proper testing before every release. Go automatically fetches them when running go build based on the info in go.mod. We can use go get -u to update the deps manually when necessary.

@adrianreber
Copy link
Member

Vendoring seems to be what many projects are doing and from my point of view it makes life easier because you have a working combination.

We can set up dependabot to ensure all dependencies are automatically updated.

@snprajwal
Copy link
Member Author

Understood, will open a PR for dependabot soon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants