Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated property maxLineLength from LeftCurlyCheck #3671

Closed
dbyron0 opened this issue Dec 20, 2016 · 5 comments
Closed

remove deprecated property maxLineLength from LeftCurlyCheck #3671

dbyron0 opened this issue Dec 20, 2016 · 5 comments
Labels
approved breaking compatibility
Milestone
8.2

Comments

@dbyron0
Copy link

dbyron0 commented Dec 20, 2016

I notice that https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml#L55 specifies a maxLineLength property for LeftCurly, but http://checkstyle.sourceforge.net/config_blocks.html#LeftCurly says it's deprecated. If it's OK to remove, I can submit a pull request.

Thanks.

-DB
@rnveach
Copy link
Member

rnveach commented Dec 20, 2016 •
edited

It is deprecated, and won't do anything if given a value.

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/LeftCurlyCheck.java

Lines 131 to 133 in 25a37e5

public void setMaxLineLength(int maxLineLength) {
// do nothing, option is deprecated
}

We are removing a lot of deprecated stuff in version 8, so most likely this item will be added to the list.
It will have to wait until we start version 8 snapshot.

@rnveach rnveach changed the title LeftCurly maxLineLength property remove deprecated property maxLineLength from LeftCurlyCheck Dec 20, 2016
Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue May 1, 2017
@Kietzmann
Issue checkstyle#3671: Remove deprecated property maxLineLength from …
b4e9453 
…LeftCurlyCheck
@MEZk MEZk mentioned this issue Jun 1, 2017
Merged
@rnveach
Copy link
Member

rnveach commented Jul 4, 2017

@romani Please see discussion at #3855 (comment) for why we don't keep this property.

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 4, 2017
Issue checkstyle#3671: Remove deprecated property maxLineLength from …
ea84248 
…LeftCurlyCheck
@Kietzmann Kietzmann mentioned this issue Jul 4, 2017
Closed
@romani
Copy link
Member

romani commented Jul 7, 2017

please share your ideas on - #3855 (comment)

@romani
Copy link
Member

romani commented Jul 27, 2017

PR referenced above was not complete and closed. New contributors are welcome to pick up this issue

@checkstyle checkstyle deleted a comment from Kietzmann Jul 27, 2017
rnveach added a commit to rnveach/checkstyle that referenced this issue Aug 3, 2017
@rnveach
Issue checkstyle#3671: removed maxLineLength in LeftCurlyCheck
32848ca
This was referenced Aug 3, 2017
Merged
Merged
Merged
romani pushed a commit that referenced this issue Aug 4, 2017
@rnveach @romani
Issue #3671: removed maxLineLength in LeftCurlyCheck
fd7fb45
@romani romani added this to the 8.2 milestone Aug 4, 2017
@romani
Copy link
Member

romani commented Aug 4, 2017

fix is merged.

@romani romani closed this as completed Aug 4, 2017
soon pushed a commit to soon/checkstyle that referenced this issue Aug 29, 2017
@rnveach @soon
Issue checkstyle#3671: removed maxLineLength in LeftCurlyCheck
4b41d89
@aaron-harris aaron-harris mentioned this issue Sep 25, 2017
Closed
anton-johansson added a commit to viskan/checkstyle-configuration that referenced this issue Jan 9, 2018
@anton-johansson
Fix breaking changes for Checkstyle 8.7
6a642ce 
Move `SuppressionCommentFilter` to `TreeWalker` (checkstyle/checkstyle#4714).
Remove `FileContentHolder` as it is no longer needed (checkstyle/checkstyle#3573).
Remove `maxLineLength` of `LeftCurlyCheck` as it has been removed (checkstyle/checkstyle#3671).

Closes #7
@anton-johansson anton-johansson mentioned this issue Jan 9, 2018
Merged
@valfirst valfirst mentioned this issue Jan 9, 2018
Merged
4 tasks
matthias-ronge pushed a commit to matthias-ronge/kitodo-production that referenced this issue Mar 14, 2018
Remove deprecated property maxLineLength from LeftCurly check
ef82732 
The option was deprecated because it did nothing and was removed in
recent versions of Checkstyle.

See: checkstyle/checkstyle#3671
spodkowinski added a commit to spodkowinski/cassandra-reaper-tlp that referenced this issue Jul 15, 2018
@spodkowinski
Fix checkstyle error maxLineLength from LeftCurlyCheck
03b895f 
Attribute has been removed and will cause an error with recent
checkstyle releases, see checkstyle/checkstyle#3671
@spodkowinski spodkowinski mentioned this issue Jul 15, 2018
Merged
michaelsembwever pushed a commit to thelastpickle/cassandra-reaper that referenced this issue Jul 16, 2018
@spodkowinski @michaelsembwever
Fix checkstyle error maxLineLength from LeftCurlyCheck
b5c91a4 
Attribute has been removed and will cause an error with recent
checkstyle releases, see checkstyle/checkstyle#3671
keith-turner added a commit to keith-turner/fluo that referenced this issue Nov 21, 2018
@keith-turner
Delete checkstyle config that is no longer supported
d447944 
checkstyle/checkstyle#3671
checkstyle/checkstyle#3573
@keith-turner keith-turner mentioned this issue Nov 21, 2018
Merged
keith-turner added a commit to apache/fluo that referenced this issue Nov 21, 2018
@keith-turner
Delete checkstyle config that is no longer supported (#1064)
96af51a 
checkstyle/checkstyle#3671
checkstyle/checkstyle#3573
tonydeng added a commit to tonydeng/tdd-tutorials that referenced this issue Jun 26, 2019
@tonydeng
🐛 fix(1.0): 删除在最新checkstyle规范中去掉的maxLineLength设置
62c28db 
checkstyle/checkstyle#3671

refs #3

Signed-off-by: Tony Deng <wolf.deng@gmail.com>
NihalJain added a commit to NihalJain/phoenix-omid that referenced this issue Oct 27, 2023
@NihalJain
OMID-258 Bump maven plugins/dependencies to latest
7df1d53 
- Bump apache parent pom version to 30
- Remove maven-assembly-plugin-version and surefire.version as it is coming from parent pom
- Bump following plugins/dependencies
  - os.plugin.version to 1.7.1
  - google.findbugs.version to 3.0.2
  - maven-pmd-plugin.version to 3.21.0
  - maven-checkstyle-plugin.version to 3.3.0
  - maven-jxr-plugin.version to 3.3.0
  - maven-findbugs-maven-plugin.version to 3.0.5
  - maven-owasp-plugin.version to 8.4.0
  - maven-clover-plugin.version to 4.5.0
  - maven-sonar-plugin.version to 3.10.0.2594
- Also updated omid_checks.xml based on updated checkstyle. Issues based on which changes were made:
  - checkstyle/checkstyle#2116
  - checkstyle/checkstyle#3671
  - checkstyle/checkstyle#7417
  - checkstyle/checkstyle#7329
@NihalJain NihalJain mentioned this issue Oct 27, 2023
Merged
chrajeshbabu pushed a commit to apache/phoenix-omid that referenced this issue Oct 31, 2023
@NihalJain
OMID-258 Bump maven plugins/dependencies to latest (#148)
3f70bcb 
- Bump apache parent pom version to 30
- Remove maven-assembly-plugin-version and surefire.version as it is coming from parent pom
- Bump following plugins/dependencies
  - os.plugin.version to 1.7.1
  - google.findbugs.version to 3.0.2
  - maven-pmd-plugin.version to 3.21.0
  - maven-checkstyle-plugin.version to 3.3.0
  - maven-jxr-plugin.version to 3.3.0
  - maven-findbugs-maven-plugin.version to 3.0.5
  - maven-owasp-plugin.version to 8.4.0
  - maven-clover-plugin.version to 4.5.0
  - maven-sonar-plugin.version to 3.10.0.2594
- Also updated omid_checks.xml based on updated checkstyle. Issues based on which changes were made:
  - checkstyle/checkstyle#2116
  - checkstyle/checkstyle#3671
  - checkstyle/checkstyle#7417
  - checkstyle/checkstyle#7329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved breaking compatibility
Projects
None yet
Milestone
8.2
Development

No branches or pull requests
3 participants
@romani @dbyron0 @rnveach