New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated property maxLineLength from LeftCurlyCheck #3671

Closed
dbyron0 opened this Issue Dec 20, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@dbyron0

dbyron0 commented Dec 20, 2016

I notice that https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml#L55 specifies a maxLineLength property for LeftCurly, but http://checkstyle.sourceforge.net/config_blocks.html#LeftCurly says it's deprecated. If it's OK to remove, I can submit a pull request.

Thanks.

-DB

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 20, 2016

Member

It is deprecated, and won't do anything if given a value.

public void setMaxLineLength(int maxLineLength) {
// do nothing, option is deprecated
}

We are removing a lot of deprecated stuff in version 8, so most likely this item will be added to the list.
It will have to wait until we start version 8 snapshot.

Member

rnveach commented Dec 20, 2016

It is deprecated, and won't do anything if given a value.

public void setMaxLineLength(int maxLineLength) {
// do nothing, option is deprecated
}

We are removing a lot of deprecated stuff in version 8, so most likely this item will be added to the list.
It will have to wait until we start version 8 snapshot.

@rnveach rnveach added the checkstyle8 label Dec 20, 2016

@rnveach rnveach changed the title from LeftCurly maxLineLength property to remove deprecated property maxLineLength from LeftCurlyCheck Dec 20, 2016

@romani romani added the approved label Dec 20, 2016

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue May 1, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 4, 2017

Member

@romani Please see discussion at #3855 (comment) for why we don't keep this property.

Member

rnveach commented Jul 4, 2017

@romani Please see discussion at #3855 (comment) for why we don't keep this property.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 7, 2017

Member

please share your ideas on - #3855 (comment)

Member

romani commented Jul 7, 2017

please share your ideas on - #3855 (comment)

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 27, 2017

Member

PR referenced above was not complete and closed. New contributors are welcome to pick up this issue

Member

romani commented Jul 27, 2017

PR referenced above was not complete and closed. New contributors are welcome to pick up this issue

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 4, 2017

Member

fix is merged.

Member

romani commented Aug 4, 2017

fix is merged.

@romani romani closed this Aug 4, 2017

soon added a commit to soon/checkstyle that referenced this issue Aug 29, 2017

anton-johansson added a commit to viskan/checkstyle-configuration that referenced this issue Jan 9, 2018

Fix breaking changes for Checkstyle 8.7
Move `SuppressionCommentFilter` to `TreeWalker` (checkstyle/checkstyle#4714).
Remove `FileContentHolder` as it is no longer needed (checkstyle/checkstyle#3573).
Remove `maxLineLength` of `LeftCurlyCheck` as it has been removed (checkstyle/checkstyle#3671).

Closes #7

@valfirst valfirst referenced this issue Jan 9, 2018

Merged

Upgrade checkstyle #802

1 of 4 tasks complete

matthias-ronge added a commit to matthias-ronge/kitodo-production that referenced this issue Mar 14, 2018

Remove deprecated property maxLineLength from LeftCurly check
The option was deprecated because it did nothing and was removed in
recent versions of Checkstyle.

See: checkstyle/checkstyle#3671

spodkowinski added a commit to spodkowinski/cassandra-reaper-tlp that referenced this issue Jul 15, 2018

Fix checkstyle error maxLineLength from LeftCurlyCheck
Attribute has been removed and will cause an error with recent
checkstyle releases, see checkstyle/checkstyle#3671

michaelsembwever added a commit to thelastpickle/cassandra-reaper that referenced this issue Jul 16, 2018

Fix checkstyle error maxLineLength from LeftCurlyCheck
Attribute has been removed and will cause an error with recent
checkstyle releases, see checkstyle/checkstyle#3671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment