idea: eights part of idea violations

[Nimfadora]

sub-task of #4681

too widespread to be included to the report:
Chained method calls 1679
Constant on right side of comparison 1880
Instance field access not qualified with this 3512
Instance method call not qualified with this 11547
Local variable or parameter can be final 3834
Nested method call 6207
Unqualified inner class access 754
Unqualified static access 4421

report on all other violations

violations names included:

ChainedMethodCall
ConstantOnRHSOfComparison
ImplicitCallToSuper
LocalCanBeFinal
NestedMethodCall
UnqualifiedFieldAccess
UnqualifiedInnerClassAccess
UnqualifiedMethodAccess
UnqualifiedStaticUsage
ReturnThis

[romani]

Implicit call to 'super()'

Suppress : "we do not like this style, but we could change our mind in future"

Return of 'this' inspection

All cases are false positives. If there are options in inspections to avoid them, lets suppress "all cases are false positives"

Local variable or parameter can be final

We do not like for final on parameters, but do use our own Check for local variables, please try to focus this inspections on variables only, if no options - suppress

Instance field access not qualified with this 3512
Instance method call not qualified with this 11547

If no options to calm down them suppress. We have our own Check(Require this) on this please look at our Check options to see what we think code should be.

Chained method calls

suppress: "it is too demanding, with no choice limits of chain size or ...."

Constant on right side of comparison

suppress: "we do like constants on the right side, is more readable, placing constant on the left does not give benefit"

Unqualified inner class access

suppress: "it is ok to skip name of outter class for inner class in filed/variable declaration to keep type short."

Unqualified static access

suppress: "inspection does not have option to skip cases of usage static field/method that is declared in the same class, as result there are a lot of want-fix cases."

[romani]

Violations included:

please activate that list of inspections and send PR(not for merge) to generate report on TC.
After each merge to our master, update that PR with list of item that still unresolved, TC will keep report for you.

[Nimfadora]

@romani this task is also done, these violations were not even included in PR with all remained violations.

[romani]

ok, am closing this issue as you confirming that all are covered.
We will recheck what is not covered at end of unmbrella issue (#4681).