Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update WriteTagCheckTest to use unique Input file in each test method #9531

Closed
romani opened this issue Mar 15, 2021 · 1 comment · Fixed by #9700
Closed

update WriteTagCheckTest to use unique Input file in each test method #9531

romani opened this issue Mar 15, 2021 · 1 comment · Fixed by #9700
Labels
approved good second issue miscellaneous

Comments

@romani
Copy link
Member

romani commented Mar 15, 2021

WriteTagCheckTest.java file reuse some Input files few time in few different test method.
Expected: each test method in Test class use it own Input file and do not share it with any other test method.

more details - https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-create-Input-files-for-tests
@AkMo3
Copy link
Contributor

AkMo3 commented Mar 21, 2021

I am on it.

AkMo3 added a commit to AkMo3/checkstyle that referenced this issue Mar 22, 2021
@AkMo3
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file
5e19806
AkMo3 added a commit to AkMo3/checkstyle that referenced this issue Mar 22, 2021
@AkMo3
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file
f77a48e
@AkMo3 AkMo3 mentioned this issue Mar 22, 2021
Merged
AkMo3 added a commit to AkMo3/checkstyle that referenced this issue Mar 23, 2021
@AkMo3
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file
09b3b32
AkMo3 added a commit to AkMo3/checkstyle that referenced this issue Mar 25, 2021
@AkMo3
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file
8f120a1
AkMo3 added a commit to AkMo3/checkstyle that referenced this issue Mar 26, 2021
@AkMo3
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file
4b25d9b
AkMo3 added a commit to AkMo3/checkstyle that referenced this issue Mar 26, 2021
@AkMo3
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file
432aeaf
AkMo3 added a commit to AkMo3/checkstyle that referenced this issue Mar 26, 2021
@AkMo3
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file
2039080
AkMo3 added a commit to AkMo3/checkstyle that referenced this issue Mar 26, 2021
@AkMo3
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file
0dd84e3
timurt pushed a commit that referenced this issue Mar 29, 2021
@AkMo3 @timurt
Issue #9531: update WriteTagCheckTest to use unique Input file
d728b6e
Ritik2604 pushed a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@AkMo3 @Ritik2604
This is a combination of 2 commits.
88c841a 
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file

Issue checkstyle#9746: update AbstractClassNameCheckTest Inp
Issue checkstyle#9746: update AbstractClassNameCheckTest Inp

Issue checkstyle#9746: update AbstractClassNameCheckTest Inp

Issue checkstyle#9746: update AbstractClassNameCheckTest Inp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved good second issue miscellaneous
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #9531: update WriteTagCheckTest to use unique Input file AkMo3/checkstyle
2 participants
@romani @AkMo3