I4681 intellij inspections #4698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CssValidation and UnusedCatchParameter
…CssValidation and UnusedCatchParameter
rnveach
reviewed
Jul 11, 2017
| @@ -575,7 +575,7 @@ public void testLoadConfigurationFromClassPath() { | |||
| final Configuration[] children = config.getChildren(); | |||
| assertEquals(0, children[0].getChildren().length); | |||
| } | |||
| catch (CheckstyleException ex) { | |||
| catch (CheckstyleException ignored) { | |||
| fail("unexpected exception"); | |||
There was a problem hiding this comment.
we should remove try-catch-fail.
| @@ -547,7 +547,7 @@ public void testLoadConfigurationDeprecated() { | |||
| final Configuration[] children = config.getChildren(); | |||
| assertEquals(0, children[0].getChildren().length); | |||
| } | |||
| catch (CheckstyleException | FileNotFoundException ex) { | |||
| catch (CheckstyleException | FileNotFoundException ignored) { | |||
| fail("unexpected exception"); | |||
| @@ -137,7 +137,7 @@ public void testTokenValueIncorrect2() throws Exception { | |||
| assertEquals("given id " + id, expected.getMessage()); | |||
|
|
|||
| } | |||
| catch (IllegalAccessException | NoSuchFieldException ex) { | |||
| catch (IllegalAccessException | NoSuchFieldException ignored) { | |||
| fail("Exception is expected"); | |||
…s, fix for code review
Codecov Report
@@ Coverage Diff @@
## master #4698 +/- ##
======================================
Coverage 100% 100%
======================================
Files 287 287
Lines 15395 15395
Branches 3502 3502
======================================
Hits 15395 15395Continue to review full report at Codecov.
|
|
manually squashed and rebase and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4681