Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5228: fixed violations for test makeup #5273

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Nov 18, 2017

Issue #5228

This fixes all violations found in test besides ones for #5157. I only had to suppress 4 cases.

@rnveach
Copy link
Member Author

rnveach commented Nov 18, 2017

One big change was in AbstractModuleTestSupport with the identification of the root module so we could just send a configuration to it with properties set instead of constantly recreating all the other properties (Thread, listener, etc) in every test.
Some places just needed this to set the cache file or add multiple children.

@codecov-io
Copy link

codecov-io commented Nov 18, 2017

Codecov Report

Merging #5273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5273   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         296     296           
  Lines       16105   16105           
  Branches     3665    3665           
======================================
  Hits        16105   16105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca6e3a...0378f0e. Read the comment docs.

@rnveach rnveach requested a review from romani November 18, 2017 19:13
@romani romani merged commit da936a0 into checkstyle:master Nov 18, 2017
@rnveach rnveach deleted the issue_5228_test branch November 19, 2017 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants