infra: pgjdbc, migrate Maven -> Gradle

[vlsi]

See pgjdbc/pgjdbc#1726 (comment)

when pgjdbc/pgjdbc#1627 is merged this PR be ready for merge.

[rnveach]

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':postgresql:checkstyleMain'.
> Could not resolve all files for configuration ':postgresql:checkstyle'.
   > Could not find com.puppycrawl.tools:checkstyle:8.31-SNAPSHOT.
     Searched in the following locations:
       - file:/root/.m2/repository/com/puppycrawl/tools/checkstyle/8.31-SNAPSHOT/maven-metadata.xml
       - file:/root/.m2/repository/com/puppycrawl/tools/checkstyle/8.31-SNAPSHOT/checkstyle-8.31-SNAPSHOT.pom
       - https://repo.maven.apache.org/maven2/com/puppycrawl/tools/checkstyle/8.31-SNAPSHOT/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/com/puppycrawl/tools/checkstyle/8.31-SNAPSHOT/checkstyle-8.31-SNAPSHOT.pom
     Required by:
         project :postgresql

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

[vlsi]

@rnveach , thanks.
Do you have access to the filesystem?

The build log says it attempted to resolve Checkstyle snapshot from Maven local repository, however, it looks like the snapshot is not there:

Searched in the following locations:
  - file:/root/.m2/repository/com/puppycrawl/tools/checkstyle/8.31-SNAPSHOT/maven-metadata.xml
  - file:/root/.m2/repository/com/puppycrawl/tools/checkstyle/8.31-SNAPSHOT/checkstyle-8.31-SNAPSHOT.pom

Can you please check if Checkstyle is installed properly?

[rnveach]

https://github.com/checkstyle/checkstyle/blob/master/wercker.yml#L58
the first thing wercker does is install the snapshot version for use with every run.

[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ checkstyle ---
[INFO] Installing /pipeline/source/target/checkstyle-8.31-SNAPSHOT.jar to /pipeline/cache/com/puppycrawl/tools/checkstyle/8.31-SNAPSHOT/checkstyle-8.31-SNAPSHOT.jar
[INFO] Installing /pipeline/source/pom.xml to /pipeline/cache/com/puppycrawl/tools/checkstyle/8.31-SNAPSHOT/checkstyle-8.31-SNAPSHOT.pom
[INFO] Installing /pipeline/source/target/checkstyle-8.31-SNAPSHOT-tests.jar to /pipeline/cache/com/puppycrawl/tools/checkstyle/8.31-SNAPSHOT/checkstyle-8.31-SNAPSHOT-tests.jar

[pzygielo]

Should this

checkstyle/wercker.yml

Line 8 in a8297ea

export MAVEN_OPTS="-Dmaven.repo.local=${WERCKER_CACHE_DIR}"

be considered/set for new gradle call as well?

It seems maven installs to /pipeline/cache but gradle is looking in /root/.m2/repository.

[vlsi]

I see there's

checkstyle/wercker.yml

Line 18 in a8297ea

ln -s ${WERCKER_CACHE_DIR} /root/.m2/repository

Is that command executed?

Frankly speaking, the command looks suspicious to me. I guess it should be ln -s ${WERCKER_CACHE_DIR} /root/.m2

I've pushed a commit that would list files in /root/.m2.
Can you please show the output from the latest wercker build?

[pzygielo]

My fault,

I see there's

checkstyle/wercker.yml

Line 18 in a8297ea

ln -s ${WERCKER_CACHE_DIR} /root/.m2/repository

I didn't ☹️

[vlsi]

wercker shows 401 for me.

Is there a way I can get permission to watch CI logs?

It is really painful to debug CI jobs which show 401 :-/

/cc @rnveach , @romani ?

[vlsi]

@rnveach, can you please help me with the new logs? (a04eb6a and 408ffa7)
That is the output of ls .. commands and the output of ./gradlew. I think it should pick GRADLE_OPTS, and it should pick -Dmaven.repo.local

[rnveach]

@vlsi Wercker passed.

[romani]

looks good, thanks a lot for update.

[rnveach]

@vlsi PR is still listed as draft. Will you be finalizing this at some time? If so, please rebase this on the latest master to ensure it will not conflict with other changes being made.

[vlsi]

The PR is still draft as the upstream pgjdbc is not migrated to Gradle yet.
My estimation is the switch will happen on the next week or so.

[vlsi]

@romani , @rnveach , pgjdbc has switched from Maven to Gradle, so please update wercker configuration.

[romani]

ok to merge if CI pass

[romani]

this is become an issue for master build of wercker - https://app.wercker.com/checkstyle/checkstyle/runs/build/5e81e9a8765d2a000763f7ce?step=5e81ea05ee64ed00087ab0fc

This PR should be expedited.

[romani]

wercker is passed, all other major validation are passed, I merged without waiting for all pass state.

[romani]

@vlsi , thanks a lot for update!

[romani]

@vlsi , I am not sure what happened but pgjdbc is still on maven in master branch.
I did revert of your commit - 522795b, to unblock all our PRs.

Please explain what happened.

[vlsi]

@romani , there was a regression in the previous release, so we did a rollback and re-released pgjdbc. Sorry for the inconvenience.

Now maven->gradle is re-applied to pgjdbc.

PS. We don't expect to rollback once again, however, it would probably make sense to use shell-script-like integration to avoid disruptions when the command line to run checkstyle changes.

[rnveach]

@vlsi Is there a central issue to track conversion to gradle so we can watch and know if something goes wrong again?

[vlsi]

It is not related to Gradle.

The issue was with a couple of fixes that were released, however, one of them introduced regressions, and another was too big to include into a minor release.

So we tried to play safe and reverted the whole thing.
Apparently, we did not expect it would ripple in the failures elsewhere.

[romani]

we switched back to gradle , wercker is passing - https://app.wercker.com/checkstyle/checkstyle/runs/build/5e849f9c7b63df001af7d8fb?step=5e849fdc1ccc9800081d78ce

@vlsi , thanks a lot for help.