Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate build scripts to Gradle #1627

Merged
merged 4 commits into from Mar 30, 2020
Merged

chore: migrate build scripts to Gradle #1627

merged 4 commits into from Mar 30, 2020

Conversation

vlsi
Copy link
Member

@vlsi vlsi commented Nov 28, 2019

Checklist

Build

Testing

  • Use JUnit 5 for test execution
  • SSL tests
  • Replication tests
  • Test coverage

Release

Release is handled with https://github.com/vlsi/vlsi-release-plugins/tree/master/plugins/stage-vote-release-plugin (which has already been tested for https://github.com/autostyle/autostyle)

Other

  • Update documentation
  • Findbugs/Spotbugs? Is it required?
  • Publish results to Sonar

@vlsi vlsi force-pushed the gradle branch 2 times, most recently from 3c12421 to a01cddf Compare Nov 28, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@vlsi
Copy link
Member Author

vlsi commented Nov 29, 2019

It turns out InsertRewriteWithAlternatingTypesIssue584 was never executed since it was never included in a test suite.

@Chrriis , I'm inclined to drop the test as it is hard to understand what the test is doing.

The failure is as in https://travis-ci.org/pgjdbc/pgjdbc/jobs/618473901#L857

org.postgresql.jdbc.InsertRewriteWithAlternatingTypesIssue584 > testPreparedStatementPreparation[insertRewrite = true] FAILED
    org.junit.ComparisonFailure: expected:<S_[1]> but was:<S_[45]>
        at org.junit.Assert.assertEquals(Assert.java:115)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at org.postgresql.jdbc.InsertRewriteWithAlternatingTypesIssue584.testPreparedStatementPreparation(InsertRewriteWithAlternatingTypesIssue584.java:133)

@vlsi vlsi force-pushed the gradle branch 2 times, most recently from 1c9e86b to 99c6140 Compare Nov 29, 2019
@davecramer
Copy link
Member

davecramer commented Nov 29, 2019

@vlsi congrats! first smoke test passed

@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@pgjdbc pgjdbc deleted a comment from AppVeyorBot Nov 29, 2019
@vlsi vlsi force-pushed the gradle branch 5 times, most recently from edb2781 to 46f0474 Compare Mar 6, 2020
@vlsi vlsi changed the title WIP: chore: add Gradle build scripts chore: add Gradle build scripts Mar 7, 2020
@vlsi vlsi changed the title chore: add Gradle build scripts chore: migrate build scripts to Gradle Mar 7, 2020
@vlsi vlsi marked this pull request as ready for review Mar 7, 2020
@vlsi vlsi added this to the 42.3.0 milestone Mar 7, 2020
@vlsi vlsi added building-and-testing triage/needs-review labels Mar 7, 2020
@vlsi vlsi force-pushed the gradle branch 2 times, most recently from efd109d to da7c49a Compare Mar 8, 2020
@vlsi vlsi force-pushed the gradle branch 2 times, most recently from 01a708e to 93bb4ec Compare Mar 25, 2020
vlsi added 4 commits Mar 30, 2020
JMH license is GPL With Classpath-Exception, so it does not require
to license user-written code under GPL.
@vlsi vlsi merged commit 8c3e046 into pgjdbc:master Mar 30, 2020
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building-and-testing triage/needs-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants