Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TeamCity #160

Closed
rnveach opened this issue Sep 26, 2018 · 2 comments
Closed

Fix TeamCity #160

rnveach opened this issue Sep 26, 2018 · 2 comments
Labels
approved
Milestone
4.12

Comments

@rnveach
Copy link
Member

rnveach commented Sep 26, 2018

https://teamcity.jetbrains.com/viewLog.html?buildId=1639807&tab=Inspection&buildTypeId=Checkstyle_SonarCheckstyleIdeaInspectionsPullRequest

Declaration redundancy
Redundant throws clause (Errors) (1)
Java 8
Statement lambda can be replaced with expression lambda (Errors) (1)
Performance
'Collection.toArray()' call style (Errors) (1)

toArray causes issues with PMD, but main repo doesn't have this problem.
@rnveach rnveach mentioned this issue Sep 26, 2018
Open
rnveach added a commit to rnveach/sonar-checkstyle that referenced this issue Sep 26, 2018
@rnveach
Issue checkstyle#160: fix teamcity violations
1daf188
@rnveach rnveach mentioned this issue Sep 27, 2018
Merged
rnveach added a commit to rnveach/sonar-checkstyle that referenced this issue Sep 27, 2018
@rnveach
Issue checkstyle#160: fixed new teamcity violations
b3749be
romani pushed a commit that referenced this issue Oct 4, 2018
@rnveach @romani
Issue #160: fixed new teamcity violations
aa7016c
@rnveach
Copy link
Member Author

rnveach commented Oct 4, 2018

Fix was merged

@rnveach rnveach closed this as completed Oct 4, 2018
@rnveach rnveach added this to the 4.12 milestone Oct 4, 2018
@romani
Copy link
Member

romani commented Oct 4, 2018

TC is green on master

tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@rnveach @tsjensen
Issue checkstyle#160: fixed new teamcity violations
0f62495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
4.12
Development

No branches or pull requests
2 participants
@romani @rnveach