Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing encrypted data bags will destroy them #5045

Closed
tas50 opened this issue May 6, 2021 · 3 comments
Closed

Editing encrypted data bags will destroy them #5045

tas50 opened this issue May 6, 2021 · 3 comments
Assignees
Labels

Comments

@tas50
Copy link
Contributor

tas50 commented May 6, 2021

Describe the bug

We need to not allow users to edit encrypted data bags in their raw format. These data bags can't be edited without the encrypted data bag secret and messing with the encrypted data will destroy the data bag.

To Reproduce

Steps to reproduce the behavior:

  • Infrastructure -> Chef Infra Servers
  • Select the server
  • Select the org
  • Click data bags
  • Select a data bag with an encrypted data bag item
  • Select the encrypted data bag items
  • Click edit

Expected behavior

Edit shouldn't be a button on encrypted data bags until we come up with a plan for handling that.

Screenshots

image

Versions (please complete the following information):

  • OS: macos
  • Browser: Firefox
  • Automate Build Number: 20210504113343

Aha! Link: https://chef.aha.io/epics/SH-E-510

@tas50 tas50 added the bug 🐛 Something isn't working label May 6, 2021
@kalroy
Copy link
Collaborator

kalroy commented Jun 1, 2021

UX behavior:

  1. Don't show the edit button.
  2. Put a note (icon) to identify an encrypted data bag
  3. Put a note beside the icon "this is an encrypted data bag"

@kalroy
Copy link
Collaborator

kalroy commented Jun 1, 2021

Question to clear:
How to identify an encrypted data bag?

@tas50
Copy link
Contributor Author

tas50 commented Jun 1, 2021

The data bag will included the "cipher" and "encrypted_data" values in the hash if it's encrypted. There may also be a way to identify it via the API, but I'm not sure about that part.

@kalroy kalroy added the Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues label Aug 4, 2021
@himanshi-chhabra himanshi-chhabra self-assigned this Sep 20, 2021
@kalroy kalroy closed this as completed Sep 21, 2021
@AnkurMundhra AnkurMundhra added Epic and removed bug 🐛 Something isn't working Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants