Automate-3144 API compliance reports node filters

[tarablack01]

🔩 Description: What code changed, and why?

When I looked into this, I realized the UI is doing the status filtering (https://github.com/chef/automate/blob/master/components/automate-ui/src/app/pages/+compliance/+reporting/+reporting-nodes/reporting-nodes.component.ts#L64).

Filtering by status is supported by backend, and won't result in results being spread across pages, so let's just move to status filtering via api.

⛓️ Related Resources

https://app.zenhub.com/workspaces/ui-team-5cba23a3b14fdc05970c8f87/issues/chef/automate/3144

👍 Definition of Done

Filtering by status is filtering via api.

👟 How to Build and Test the Change

hab studio enter
export DEVPROXY_URL=localhost
build components/automate-ui-devproxy
start_automate_ui_background
start_all_services
chef_load_nodes

✅ Checklist

• I have read the CONTRIBUTING document.
• All commits have been signed-off for the Developer Certification of Origin.

📷 Screenshots, if applicable

[vjeffrey]

it looks like the status filter is being applied to the summary api call as well as the nodes api call - meaning the total counts and overall status are affected by the filter on the table list. i'd like ux to review to see if this is desired behavior or if the filter should only be applied to the nodes api call/only affect the list items

[tarablack01]

@vjeffrey thanks for finding that and also requesting UX team verify the desired result. I know why this is happening as all the filters are processed through the parent reporting component. If this needs to be changed, I can do that. 😊

[susanev]

good catch! summary data should not change based on the filters. the filters appear below the summary and within the tabs. so visually folks will not expect the summary data to change as they adjust the filters.

[jonong1972]

Yeah this is wonky. I think I understand the reason why the system is doing what its doing. If I recall correctly the search was built as if a user were to search on something, that would affect the status? For instance, show me all nodes with Control X, and then reflect status of nodes based on Control X - which then would update the Summary? I could be wrong though.

[tarablack01]

@vjeffrey @susanev @jonong1972 Fixed filtering to be only nodes.

[vjeffrey]

working great thank you!

[susanev]

cool thank you!! i think this pr now addresses #3674 too
noticed that when navigating between the tabs that the node status filter persists but the profile one does not. we prolly want those to be consistent. @jonong1972 do you want them to persist when navigating between the tabs or not?

oh wait, also the url...
if i go to nodes and select failed it changes to compliance/reports/nodes?status=failed
then if i navigate to profiles it adjusts to compliance/reports/profiles?status=failed but it shows total selected since i didnt choose the failed status on profiles.
should we fix this? or i guess that status is for nodes only, so prolly the same thing as mentioned above

okay ill stop editing this now

[jonong1972]

@susanev yes. would be great it would persist. But I think in order for that to happen for each respective tab we would probably have to change the query param from something like. "?status=failed" to "?node_status=failed&profile_status=failed"

[tarablack01]

@jonong1972 @susanev the status will persist. We just need to hook up profiles with api status filtering. 😊