Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance report: Pagination component not being updated when the status filter is applied. #3673

Closed
susanev opened this issue May 13, 2020 · 0 comments
Assignees
Labels
automate-ui bug 🐛 Something isn't working ui

Comments

@susanev
Copy link
Contributor

susanev commented May 13, 2020

overview

There is a dependency on #3664

Prior to #3664, if you applied a status filter the nodes, profiles, or controls would still be distributed across all of their pages before the filter was applied.

#3664 improves it so that all objects get moved to the beginning of the pages, but all the empty pages are left around and if a user navigates to one of the empty pages they get stuck and have to do a hard refresh.

if a user applies a status filter, pagination buttons should only be shown if there are objects on them.

repro

internal slack video

  • add at least 101 compliance nodes, chef_load_compliance_nodes
  • navigate to compliance > reports > nodes (or profiles or controls)
  • apply a status filter
  • navigate to the second page via the pagination component
  • notice the blank pages where you get stuck

definition of done

when a user applies a status filter, pagination is recalculated and all results are shown on the first pages and no pagination buttons are shown with no data on them and users arent able to get stuck

@susanev susanev added bug 🐛 Something isn't working ui automate-ui labels May 13, 2020
@jonong1972 jonong1972 changed the title compliance pagination woes Compliance report: Status filter no applying results to the pagination component May 15, 2020
@jonong1972 jonong1972 changed the title Compliance report: Status filter no applying results to the pagination component Compliance report: Status filter not applying results to the pagination component May 15, 2020
@jonong1972 jonong1972 changed the title Compliance report: Status filter not applying results to the pagination component Compliance report: Pagination component not being updated when the status filter is applied. May 15, 2020
@tarablack01 tarablack01 self-assigned this May 15, 2020
@SEAjamieD SEAjamieD assigned SEAjamieD and unassigned tarablack01 Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-ui bug 🐛 Something isn't working ui
Projects
None yet
Development

No branches or pull requests

4 participants