-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added delete option in policy files #5321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: 462ab82 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60ec5c491660f600075471ce |
vinay033
approved these changes
Jul 9, 2021
Venkatesh-rengasamy
approved these changes
Jul 9, 2021
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
82d2b38
to
462ab82
Compare
Kudos, SonarCloud Quality Gate passed!
|
kalroy
added a commit
that referenced
this pull request
Jul 15, 2021
…section to Chef Infra Server (#5316) * created a list of headers to be added to the cookbook section in chef infra Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * added the cookbook section to the chef infra server page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes on cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * images updated Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Added search bar in policy files (#5307) * added search bar in policy files Signed-off-by: chaitali-mane <cmane@progress.com> * Added cypress test cases Signed-off-by: chaitali-mane <cmane@progress.com> * minor change Signed-off-by: chaitali-mane <cmane@progress.com> * Added code for pagination updation Signed-off-by: chaitali-mane <cmane@progress.com> * Added unit tests Signed-off-by: chaitali-mane <cmane@progress.com> * Ensure /usr/local/bin is in PATH (#5311) * Ensure /usr/local/bin is in PATH Some platforms will not have /usr/local/bin in their PATH Signed-off-by: Tom Duffield <github@tomduffield.com> * Have install script create chef-ci user Signed-off-by: Tom Duffield <github@tomduffield.com> * added missing brackets to doc (#5318) Signed-off-by: Vivek Shankar <vshankar@progress.com> * added policy file section to the chef infra server page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Event Service document (#5214) * Event feed document Signed-off-by: PratyakshaSinha <email_address@domain.com> * Event Feed document formatting Signed-off-by: Kallol Roy <karoy@progress.com> * Adding config possibilities Signed-off-by: Kallol Roy <karoy@progress.com> Co-authored-by: PratyakshaSinha <email_address@domain.com> Co-authored-by: Kallol Roy <karoy@progress.com> * edited images for the chef infra page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Bump automate-compliance-profiles (#5297) This pull request was triggered automatically via Expeditor. This change falls under the obvious fix policy so no Developer Certificate of Origin (DCO) sign-off is required. Co-authored-by: Chef Expeditor <chef-ci@chef.io> * add some more verbage to describe requirements for deep filtering (#5266) * add some more verbage to discribe requirements for deep filtering Signed-off-by: Rick Marry <rick.marry@gmail.com> * Docs edits Signed-off-by: kagarmoe <kgarmoe@chef.io> * even shorter Signed-off-by: kagarmoe <kgarmoe@chef.io> * shortest Signed-off-by: kagarmoe <kgarmoe@chef.io> * word choice Signed-off-by: kagarmoe <kgarmoe@chef.io> * symmetry Signed-off-by: kagarmoe <kgarmoe@chef.io> Co-authored-by: kagarmoe <kgarmoe@chef.io> * ldap server setup dev-docs update (#5203) * ldap server setup dev-docs update * Changed some formats and rewrote some comments Signed-off-by: Kallol Roy <karoy@progress.com> Co-authored-by: Kallol Roy <karoy@progress.com> * minor fixes Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes in cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes in policyfile section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Update components/docs-chef-io/content/automate/chef_infra_server.md Co-authored-by: Kimberly Garmoe <kgarmoe@chef.io> * added image for the policyfile tab Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * update headers and pointers in cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Added search text changes. (#5326) Signed-off-by: Himanshi Chhabra <hchhabra@progress.com> * fixes in chef infra section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * updated image of policyfiles section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Removed bintray dependencies from deployment (#5328) * Removed bintray dependecies from deployment Signed-off-by: Kallol Roy <karoy@progress.com> * New bundle creator Signed-off-by: Kallol Roy <karoy@progress.com> * Removed bin from test Signed-off-by: Kallol Roy <karoy@progress.com> * Removed date versioned hab from test Signed-off-by: Kallol Roy <karoy@progress.com> * Getting Binlink back Signed-off-by: Kallol Roy <karoy@progress.com> * Migrate away from Bintray for migration Signed-off-by: Kallol Roy <karoy@progress.com> * Added delete option in policy files (#5321) * Added UI for delete part Signed-off-by: chaitali-mane <cmane@progress.com> * Added API integration Signed-off-by: chaitali-mane <cmane@progress.com> * Added test cases Signed-off-by: chaitali-mane <cmane@progress.com> * Updated API integration code Signed-off-by: chaitali-mane <cmane@progress.com> * minor change Signed-off-by: chaitali-mane <cmane@progress.com> * Minor change Signed-off-by: chaitali-mane <cmane@progress.com> * Minor change Signed-off-by: chaitali-mane <cmane@progress.com> * Security Improvements in Load balancer (#5286) * Enable HSTS policy for the routes which does not have the header set as of now. Signed-off-by: Kallol Roy <karoy@progress.com> * More security fixes Signed-off-by: Kallol Roy <karoy@progress.com> * Review changes are done Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> Co-authored-by: Venkatesh-rengasamy <vrengasa@progress.com> * Venkatesh/telemetry preference save UI (#5284) * Telemetry Pref is restored while login Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning - remove unnecessary changes Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning - remove unnecessary changes Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Telemetry Preference issue Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Show telemetry warning message if preference is disabled Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleanup Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Restrict unnecessary api calls for segment write key Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * add static warning message with checkbox Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Update warning message and its alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleanup Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * anchor tag security issue in pipeline Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * Telemetry Pref is restored while login Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning - remove unnecessary changes Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning - remove unnecessary changes Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Telemetry Preference issue Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Show telemetry warning message if preference is disabled Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleanup Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Restrict unnecessary api calls for segment write key Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * add static warning message with checkbox Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Update warning message and its alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleanup Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * anchor tag security issue in pipeline Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * upgrade highlight.js version Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * upgrade typedoc version for build error Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * fix protactor failed case - telemetry Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * revert typedoc version changes (#5354) Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * minor fixes for content tab Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * created a list of headers to be added to the cookbook section in chef infra Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * added the cookbook section to the chef infra server page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes on cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * images updated Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * added policy file section to the chef infra server page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * edited images for the chef infra page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes in cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes in policyfile section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * fixing conflicts Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * added image for the policyfile tab Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * update headers and pointers in cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * fixing conflicts Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * updated image of policyfiles section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes for content tab Signed-off-by: Dishank Tiwari <dtiwari@progress.com> Co-authored-by: Chaitali Mane <71449322+chaitali-mane@users.noreply.github.com> Co-authored-by: Tom Duffield <tom@chef.io> Co-authored-by: vivekshankar1 <59958706+vivekshankar1@users.noreply.github.com> Co-authored-by: Pratyaksha Sinha <65227203+PratyakshaSinha@users.noreply.github.com> Co-authored-by: PratyakshaSinha <email_address@domain.com> Co-authored-by: Kallol Roy <karoy@progress.com> Co-authored-by: chef-expeditor[bot] <49165653+chef-expeditor[bot]@users.noreply.github.com> Co-authored-by: Chef Expeditor <chef-ci@chef.io> Co-authored-by: Rick Marry <rmarry@chef.io> Co-authored-by: kagarmoe <kgarmoe@chef.io> Co-authored-by: Abdul Azeez <aazeez@progress.com> Co-authored-by: Himanshi Chhabra <61003053+himanshi-chhabra@users.noreply.github.com> Co-authored-by: Venkatesh-rengasamy <vrengasa@progress.com> Co-authored-by: Venkatesh-rengasamy <84014872+Venkatesh-rengasamy@users.noreply.github.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chaitali Mane cmane@progress.com
🔩 Description: What code changed, and why?
User can delete individual policy file from policy files list.
⛓️ Related Resources
#5241
👍 Definition of Done
Added delete option to each policy file.
👟 How to Build and Test the Change
Steps for Policyfiles tab:
Go To Infrastructure -> Chef Servers -> click server name-> click on org name -> Policyfiles.
For cypress Build
https://github.com/chef/automate/tree/master/e2e
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Delete option available :
![policy-delete](https://user-images.githubusercontent.com/71449322/124765823-fde73600-df53-11eb-809d-b72e342c077b.png)
Delete modal for Policy file:
![delete-policy1](https://user-images.githubusercontent.com/71449322/124766119-40107780-df54-11eb-8e51-07dcc02ad15f.png)