Venkatesh/telemetry preference save UI #5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
|
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: 889b5a9 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60ed76125842e20008538ba5 |
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
kalroy
force-pushed
the
venkatesh/telemetry-preference-save-UI
branch
from
e719440
to
ec8f8ae
Compare
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
…ub.com/chef/automate into venkatesh/telemetry-preference-save-UI
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
|
Kudos, SonarCloud Quality Gate passed!
|
kalroy
added a commit
that referenced
this pull request
Jul 15, 2021
…section to Chef Infra Server (#5316) * created a list of headers to be added to the cookbook section in chef infra Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * added the cookbook section to the chef infra server page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes on cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * images updated Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Added search bar in policy files (#5307) * added search bar in policy files Signed-off-by: chaitali-mane <cmane@progress.com> * Added cypress test cases Signed-off-by: chaitali-mane <cmane@progress.com> * minor change Signed-off-by: chaitali-mane <cmane@progress.com> * Added code for pagination updation Signed-off-by: chaitali-mane <cmane@progress.com> * Added unit tests Signed-off-by: chaitali-mane <cmane@progress.com> * Ensure /usr/local/bin is in PATH (#5311) * Ensure /usr/local/bin is in PATH Some platforms will not have /usr/local/bin in their PATH Signed-off-by: Tom Duffield <github@tomduffield.com> * Have install script create chef-ci user Signed-off-by: Tom Duffield <github@tomduffield.com> * added missing brackets to doc (#5318) Signed-off-by: Vivek Shankar <vshankar@progress.com> * added policy file section to the chef infra server page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Event Service document (#5214) * Event feed document Signed-off-by: PratyakshaSinha <email_address@domain.com> * Event Feed document formatting Signed-off-by: Kallol Roy <karoy@progress.com> * Adding config possibilities Signed-off-by: Kallol Roy <karoy@progress.com> Co-authored-by: PratyakshaSinha <email_address@domain.com> Co-authored-by: Kallol Roy <karoy@progress.com> * edited images for the chef infra page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Bump automate-compliance-profiles (#5297) This pull request was triggered automatically via Expeditor. This change falls under the obvious fix policy so no Developer Certificate of Origin (DCO) sign-off is required. Co-authored-by: Chef Expeditor <chef-ci@chef.io> * add some more verbage to describe requirements for deep filtering (#5266) * add some more verbage to discribe requirements for deep filtering Signed-off-by: Rick Marry <rick.marry@gmail.com> * Docs edits Signed-off-by: kagarmoe <kgarmoe@chef.io> * even shorter Signed-off-by: kagarmoe <kgarmoe@chef.io> * shortest Signed-off-by: kagarmoe <kgarmoe@chef.io> * word choice Signed-off-by: kagarmoe <kgarmoe@chef.io> * symmetry Signed-off-by: kagarmoe <kgarmoe@chef.io> Co-authored-by: kagarmoe <kgarmoe@chef.io> * ldap server setup dev-docs update (#5203) * ldap server setup dev-docs update * Changed some formats and rewrote some comments Signed-off-by: Kallol Roy <karoy@progress.com> Co-authored-by: Kallol Roy <karoy@progress.com> * minor fixes Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes in cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes in policyfile section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Update components/docs-chef-io/content/automate/chef_infra_server.md Co-authored-by: Kimberly Garmoe <kgarmoe@chef.io> * added image for the policyfile tab Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * update headers and pointers in cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Added search text changes. (#5326) Signed-off-by: Himanshi Chhabra <hchhabra@progress.com> * fixes in chef infra section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * updated image of policyfiles section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * Removed bintray dependencies from deployment (#5328) * Removed bintray dependecies from deployment Signed-off-by: Kallol Roy <karoy@progress.com> * New bundle creator Signed-off-by: Kallol Roy <karoy@progress.com> * Removed bin from test Signed-off-by: Kallol Roy <karoy@progress.com> * Removed date versioned hab from test Signed-off-by: Kallol Roy <karoy@progress.com> * Getting Binlink back Signed-off-by: Kallol Roy <karoy@progress.com> * Migrate away from Bintray for migration Signed-off-by: Kallol Roy <karoy@progress.com> * Added delete option in policy files (#5321) * Added UI for delete part Signed-off-by: chaitali-mane <cmane@progress.com> * Added API integration Signed-off-by: chaitali-mane <cmane@progress.com> * Added test cases Signed-off-by: chaitali-mane <cmane@progress.com> * Updated API integration code Signed-off-by: chaitali-mane <cmane@progress.com> * minor change Signed-off-by: chaitali-mane <cmane@progress.com> * Minor change Signed-off-by: chaitali-mane <cmane@progress.com> * Minor change Signed-off-by: chaitali-mane <cmane@progress.com> * Security Improvements in Load balancer (#5286) * Enable HSTS policy for the routes which does not have the header set as of now. Signed-off-by: Kallol Roy <karoy@progress.com> * More security fixes Signed-off-by: Kallol Roy <karoy@progress.com> * Review changes are done Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> Co-authored-by: Venkatesh-rengasamy <vrengasa@progress.com> * Venkatesh/telemetry preference save UI (#5284) * Telemetry Pref is restored while login Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning - remove unnecessary changes Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning - remove unnecessary changes Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Telemetry Preference issue Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Show telemetry warning message if preference is disabled Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleanup Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Restrict unnecessary api calls for segment write key Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * add static warning message with checkbox Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Update warning message and its alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleanup Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * anchor tag security issue in pipeline Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * Telemetry Pref is restored while login Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning - remove unnecessary changes Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning - remove unnecessary changes Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Telemetry Preference issue Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleaning Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Show telemetry warning message if preference is disabled Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleanup Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Restrict unnecessary api calls for segment write key Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * add static warning message with checkbox Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * update alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Update warning message and its alignment Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * Code cleanup Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com> * anchor tag security issue in pipeline Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * upgrade highlight.js version Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * upgrade typedoc version for build error Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * fix protactor failed case - telemetry Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * revert typedoc version changes (#5354) Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com> * minor fixes for content tab Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * created a list of headers to be added to the cookbook section in chef infra Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * added the cookbook section to the chef infra server page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes on cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * images updated Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * added policy file section to the chef infra server page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * edited images for the chef infra page Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes in cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes in policyfile section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * fixing conflicts Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * added image for the policyfile tab Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * update headers and pointers in cookbook section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * fixing conflicts Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * updated image of policyfiles section Signed-off-by: Dishank Tiwari <dtiwari@progress.com> * minor fixes for content tab Signed-off-by: Dishank Tiwari <dtiwari@progress.com> Co-authored-by: Chaitali Mane <71449322+chaitali-mane@users.noreply.github.com> Co-authored-by: Tom Duffield <tom@chef.io> Co-authored-by: vivekshankar1 <59958706+vivekshankar1@users.noreply.github.com> Co-authored-by: Pratyaksha Sinha <65227203+PratyakshaSinha@users.noreply.github.com> Co-authored-by: PratyakshaSinha <email_address@domain.com> Co-authored-by: Kallol Roy <karoy@progress.com> Co-authored-by: chef-expeditor[bot] <49165653+chef-expeditor[bot]@users.noreply.github.com> Co-authored-by: Chef Expeditor <chef-ci@chef.io> Co-authored-by: Rick Marry <rmarry@chef.io> Co-authored-by: kagarmoe <kgarmoe@chef.io> Co-authored-by: Abdul Azeez <aazeez@progress.com> Co-authored-by: Himanshi Chhabra <61003053+himanshi-chhabra@users.noreply.github.com> Co-authored-by: Venkatesh-rengasamy <vrengasa@progress.com> Co-authored-by: Venkatesh-rengasamy <84014872+Venkatesh-rengasamy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Scenario: 1) Telemetry preference is saved locally but its not restored in Checkbox when user login again.
Scenario: 2) User should not wait for About popup to start the telemetry service. Expectation is that telemetry service should run when user login and if telemetry preference is enabled.
Scenario: 3) Append the static message with checkbox in the About popup - "For the changes to take effect, please logout and re-login again."
⛓️ Related Resources
#5271
👍 Definition of Done
Telemetry preference is restored from localstorage and updated on its binded property. Telemetry service will run when user login and if telemetry preference is enabled. Added the static message with checkbox in the About popup.
👟 How to Build and Test the Change
Go to the 'Profile menu' from the top right corner then click it and see the list of menu items. Select the About menu in the list --> you can see the About popup will open --> uncheck the second checkbox(telemetry pref) and close the About popup --> logout from the app --> Again login --> open the About popup from profile menu --> you can see the second checkbox is unchecked in About popup
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable