Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Screenshots, add content to Cookbook section & add Policyfile section to Chef Infra Server #5316

Merged
merged 45 commits into from
Jul 15, 2021

Conversation

dishanktiwari2501
Copy link
Collaborator

@dishanktiwari2501 dishanktiwari2501 commented Jul 2, 2021

🔩 Description: What code changed, and why?

  • The previous screenshots were outdated due to the new section added to the UI.
  • Added content to the Cookbook section
  • Added a new section - Policyfile

⛓️ Related Resources

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

… infra

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
@dishanktiwari2501 dishanktiwari2501 added the documentation Anything related to the Automate docs. label Jul 2, 2021
@dishanktiwari2501 dishanktiwari2501 self-assigned this Jul 2, 2021
@netlify
Copy link

netlify bot commented Jul 2, 2021

✔️ Deploy Preview for chef-automate ready!

🔨 Explore the source changes: f5690e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60efd3540afb750007d921a6

😎 Browse the preview: https://deploy-preview-5316--chef-automate.netlify.app/automate/chef_infra_server

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
* added search bar in policy files

Signed-off-by: chaitali-mane <cmane@progress.com>

* Added cypress test cases

Signed-off-by: chaitali-mane <cmane@progress.com>

* minor change

Signed-off-by: chaitali-mane <cmane@progress.com>

* Added code for pagination updation

Signed-off-by: chaitali-mane <cmane@progress.com>

* Added unit tests

Signed-off-by: chaitali-mane <cmane@progress.com>
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good draft! The information design for this section is solid, I left a lot of writing feedback.

tduffield and others added 5 commits July 7, 2021 10:12
* Ensure /usr/local/bin is in PATH

Some platforms will not have /usr/local/bin in their PATH

Signed-off-by: Tom Duffield <github@tomduffield.com>

* Have install script create chef-ci user

Signed-off-by: Tom Duffield <github@tomduffield.com>
Signed-off-by: Vivek Shankar <vshankar@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
* Event feed document

Signed-off-by: PratyakshaSinha <email_address@domain.com>

* Event Feed document formatting

Signed-off-by: Kallol Roy <karoy@progress.com>

* Adding config possibilities

Signed-off-by: Kallol Roy <karoy@progress.com>

Co-authored-by: PratyakshaSinha <email_address@domain.com>
Co-authored-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
@dishanktiwari2501 dishanktiwari2501 changed the title Add Contents to the Cookbook section in Chef infra Server Update Screenshots, add content to Cookbook section & add Policyfile section to Chef Infra Server Jul 7, 2021
@chef chef deleted a comment from kagarmoe Jul 7, 2021
chef-expeditor bot and others added 11 commits July 7, 2021 21:10
This pull request was triggered automatically via Expeditor.

This change falls under the obvious fix policy so no Developer Certificate of Origin (DCO) sign-off is required.

Co-authored-by: Chef Expeditor <chef-ci@chef.io>
)

* add some more verbage to discribe requirements for deep filtering

Signed-off-by: Rick Marry <rick.marry@gmail.com>

* Docs edits

Signed-off-by: kagarmoe <kgarmoe@chef.io>

* even shorter

Signed-off-by: kagarmoe <kgarmoe@chef.io>

* shortest

Signed-off-by: kagarmoe <kgarmoe@chef.io>

* word choice

Signed-off-by: kagarmoe <kgarmoe@chef.io>

* symmetry

Signed-off-by: kagarmoe <kgarmoe@chef.io>

Co-authored-by: kagarmoe <kgarmoe@chef.io>
* ldap server setup dev-docs update

* Changed some formats and rewrote some comments

Signed-off-by: Kallol Roy <karoy@progress.com>

Co-authored-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Co-authored-by: Kimberly Garmoe <kgarmoe@chef.io>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopened two discussions and added a few more suggestions.

dishanktiwari2501 and others added 7 commits July 12, 2021 13:44
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
* Removed bintray dependecies from deployment

Signed-off-by: Kallol Roy <karoy@progress.com>

* New bundle creator

Signed-off-by: Kallol Roy <karoy@progress.com>

* Removed bin from test

Signed-off-by: Kallol Roy <karoy@progress.com>

* Removed date versioned hab from test

Signed-off-by: Kallol Roy <karoy@progress.com>

* Getting Binlink back

Signed-off-by: Kallol Roy <karoy@progress.com>

* Migrate away from Bintray for migration

Signed-off-by: Kallol Roy <karoy@progress.com>
* Added UI for delete part

Signed-off-by: chaitali-mane <cmane@progress.com>

* Added API integration

Signed-off-by: chaitali-mane <cmane@progress.com>

* Added test cases

Signed-off-by: chaitali-mane <cmane@progress.com>

* Updated API integration code

Signed-off-by: chaitali-mane <cmane@progress.com>

* minor change

Signed-off-by: chaitali-mane <cmane@progress.com>

* Minor change

Signed-off-by: chaitali-mane <cmane@progress.com>

* Minor change

Signed-off-by: chaitali-mane <cmane@progress.com>
* Enable HSTS policy for the routes which does not have the header set as of now.

Signed-off-by: Kallol Roy <karoy@progress.com>

* More security fixes

Signed-off-by: Kallol Roy <karoy@progress.com>

* Review changes are done

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>

Co-authored-by: Venkatesh-rengasamy <vrengasa@progress.com>
* Telemetry Pref is restored while login

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleaning - remove unnecessary changes

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleaning - remove unnecessary changes

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Telemetry Preference issue

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleaning

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Show telemetry warning message if preference is disabled

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleanup

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Restrict unnecessary api calls for segment write key

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* add static warning message with checkbox

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* update alignment

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* update alignment

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* update alignment

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Update warning message and its alignment

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleanup

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* anchor tag security issue in pipeline

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>

* Telemetry Pref is restored while login

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleaning - remove unnecessary changes

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleaning - remove unnecessary changes

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Telemetry Preference issue

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleaning

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Show telemetry warning message if preference is disabled

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleanup

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Restrict unnecessary api calls for segment write key

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* add static warning message with checkbox

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* update alignment

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* update alignment

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* update alignment

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Update warning message and its alignment

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* Code cleanup

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>

* anchor tag security issue in pipeline

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>

* upgrade highlight.js version

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>

* upgrade typedoc version for build error

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>

* fix protactor failed case - telemetry

Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Signed-off-by: Venkatesh-rengasamy <vrengasa@progress.com>
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-186336401

… infra

Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
…automate into dt_add-content-to-cookbook-section
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalroy kalroy merged commit 7ed9771 into master Jul 15, 2021
@kalroy kalroy deleted the dt_add-content-to-cookbook-section branch July 15, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants