Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosted: POST and PUT /groups accept users, clients or groups but do nothing with them #605

Open
jkeiser opened this issue Nov 4, 2015 · 5 comments
Labels
Status: To be prioritized Indicates that product needs to prioritize this issue. Triage: Confirmed Indicates and issue has been confirmed as described. Triage: Try Reproducing Indicates that this issue needs to be reproduced.

Comments

@jkeiser
Copy link
Contributor

jkeiser commented Nov 4, 2015

POST /groups accepts "users", "clients" and "groups" as input (does not throw a 400), but does not populate them. PUT /groups/x does the same, even returning them from the request. This appears to be at least a partial cause of chef/cheffish#90 .

When I have an org named essentials and a file x.json:

{
  "users": [
    "jkeiser"
  ],
  "clients": [
    "essentials-validator"
  ],
  "groups": [
    "admins"
  ],
  "orgname": "essentials",
  "name": "x",
  "groupname": "x"
}

I see the following:

jkeiser@Ettores-MacBook-Pro-2 ~/e/essentials> knife raw -m POST /groups -i x.json
{
  "uri": "https://api.opscode.com/organizations/essentials/groups/x"
}
jkeiser@Ettores-MacBook-Pro-2 ~/e/essentials> knife raw /groups/x
{
  "actors": [
  ],
  "users": [
  ],
  "clients": [
  ],
  "groups": [
  ],
  "orgname": "essentials",
  "name": "x",
  "groupname": "x"
}

If I follow it up with a PUT from the same file, I get:

jkeiser@Ettores-MacBook-Pro-2 ~/e/essentials> knife raw -m PUT /groups/x -i x.json
{
  "users": [
    "jkeiser"
  ],
  "clients": [
    "essentials-validator"
  ],
  "groups": [
    "admins"
  ],
  "orgname": "essentials",
  "name": "x",
  "groupname": "x"
}
jkeiser@Ettores-MacBook-Pro-2 ~/e/essentials> knife raw /groups/x
{
  "actors": [
  ],
  "users": [
  ],
  "clients": [
  ],
  "groups": [
  ],
  "orgname": "essentials",
  "name": "x",
  "groupname": "x"
}
@stevendanna
Copy link
Contributor

@jkeiser Yes, at least the POST behavior is chef 12 change that I pointed out a while ago, I'll dig up the old ticket.

@stevendanna
Copy link
Contributor

I can't seem to find where the issue on client-support for the new POST behavior went; however, that PUT behavior definitely seems incorrect and is worth investigating further.

@pburkholder
Copy link
Contributor

@stevendanna Have you been able to follow up on this, or do you need some help on the further investigation front?

1 similar comment
@pburkholder
Copy link
Contributor

@stevendanna Have you been able to follow up on this, or do you need some help on the further investigation front?

@MathildeBarr
Copy link

@jkeiser @stevendanna Do you need any additional information on this from the customer?

@PrajaktaPurohit PrajaktaPurohit added Status: To be prioritized Indicates that product needs to prioritize this issue. Triage: Confirmed Indicates and issue has been confirmed as described. Triage: Try Reproducing Indicates that this issue needs to be reproduced. and removed investigation-required labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: To be prioritized Indicates that product needs to prioritize this issue. Triage: Confirmed Indicates and issue has been confirmed as described. Triage: Try Reproducing Indicates that this issue needs to be reproduced.
Projects
None yet
Development

No branches or pull requests

5 participants