chef_client_config resource #10365
Merged
chef_client_config resource #10365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
force-pushed
the
chef_config
branch
4 times, most recently
from
b8ad8da
to
0e852c3
Compare
tas50
force-pushed
the
chef_config
branch
2 times, most recently
from
b942128
to
f8ddfa7
Compare
tas50
force-pushed
the
chef_config
branch
5 times, most recently
from
c781d9d
to
dd3de44
Compare
Initial stab at a chef_client_config resource that will allow people to easily write out a client.rb. This isn't meant to cover every single use case, but instead to provide a simple resource that works for 99% of users. Signed-off-by: Tim Smith <tsmith@chef.io>
|
We can probably start conversations around this |
Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
Oct 12, 2020
phiggins
reviewed
Oct 12, 2020
phiggins
reviewed
Oct 12, 2020
phiggins
reviewed
Oct 12, 2020
phiggins
reviewed
Oct 12, 2020
2.0 is out with Ruby 2.7 support Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
It's several months EOL at this point Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
Oct 13, 2020
| DESC | ||
|
|
||
| property :formatters, Array, | ||
| description: "", |
There was a problem hiding this comment.
Does this need to get filled in?
phiggins
reviewed
Oct 13, 2020
| default: [] | ||
|
|
||
| property :event_loggers, Array, | ||
| description: "", |
There was a problem hiding this comment.
Does this need to get filled in?
There was a problem hiding this comment.
Yep there's some missing descriptions at the moment due to descriptions missing on the docs site overall*
phiggins
reviewed
Oct 13, 2020
phiggins
reviewed
Oct 13, 2020
|
LGTM, but I should probably not be the final review on this one. |
|
Whoops 😅 |
This makes it easier to read and easier to test Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
Oct 13, 2020
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Also give people and out. Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial stab at a chef_client_config resource that will allow people to easily write out a client.rb. This isn't meant to cover every single use case, but instead to provide a simple resource that works for 99% of users.
Signed-off-by: Tim Smith tsmith@chef.io