[CHEF-5037] default to IPS packages on Solaris 5.11+

[ccope]

This behavior was correct until 7fa1ea5 flipped the logic.

[elijah]

Does this work on Solaris 11+ without trashing the behavior on e.g. SmartOS, where pkgin is the method rather than IPS? I'm not familiar with where the conditionals for that are - I usually use a pkgin cookbook myself, but others may not know to do so, or understand the differences...

[lamont-granquist]

SmartOS is a different block that uses this class:

Chef::Provider::Package::SmartOS

The "Solaris" and "IPS" package providers are both wrong for smartos, this doesn't affect them, just fixes solaris.

[lamont-granquist]

@ccope any chance for some specs to test this in spec/platform_spec.rb so that it doesn't break again?

it looks like the existing unit tests are kind of bad for this and you'd need to probably wrap the existing tests with a "context 'while testing with fake data'" or something and then have a "context 'while testing the configured platform data'" and then make sure that Chef::Platform.find("Solaris", "5.9") gets the right package provider. we don't do anything like this right now. let me know if you need help.

[ccope]

@lamont-granquist Sure. I haven't done much rspec before, but both of these seem to work. Is there a preferred style?

it "should use the solaris package provider on Solaris <11" do
  Chef::Platform.find("Solaris2", "5.9")[:package].should eql(Chef::Provider::Package::Solaris)
end

it "should use the IPS package provider on Solaris 11" do
  pmap = Chef::Platform.find("Solaris2", "5.11")
  pmap[:package].should eql(Chef::Provider::Package::Ips)
end

[lamont-granquist]

Style should mostly just match the style of the spec file that you're modifying. The use of let variables over instance variables is highly encouraged, but not an issue in this case. Those look fine.

I prefer the new expect().to syntax now, but like consistency throughout the spec file better, and you shouldn't need to update the whole thing for this patch.

[lamont-granquist]

LGTM