Do downcase on Windows environment key_name too

[alex-slynko]

Issue breaks windows_path

[sersut]

Hrmm... Do we need to downcase all the time or try to find the key name that already is existing on the node? I.e. what happens when the path env variable is set as Path on the box?

/cc: @adamedx

[btm]

This probably fixes chef-boneyard/windows#105. We definitely need a test added here. /cc @adamedx

[adamedx]

Basic issue is that previously we did direct WQL queries via the ruby-wmi gem, and wql by default is case insensitive. With the switch to wmi-lite to do this without a WQL query, we need to emulate case insensitivity, which we are not doing. This fix addresses the issue. Another fix would be to simply use the 'query' method instead of instances_of, and allow wql to process the query.

Here is an example which shows what's broken:

env "envBUG" do
  action :delete
end

env "envbug" do
  action :create
  value 'stuff'
end

# This will crash, since 'envBUG' doesn't exist 
# if you do a case sensitive comparison.
env "envBUG" do
  action :modify
  value 'stuff2'
end

[btm]

Thanks guys. This is superseded by #1774.