Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkeypatch Win32::Registry methods delete_key, delete_value #3870

Closed
wants to merge 6 commits into from

Conversation

mcquin
Copy link
Contributor

@mcquin mcquin commented Sep 3, 2015

  • Adds monkeypatches for Win32::Registry#delete_key and Win32::Registry#delete_value.
  • Rewrites Chef::Win32::Registry#delete_key to use Win32::Registry#delete_key.

(Note: Once this is merged, I will move the Win32::Registry#write monkeypatch into lib/chef/monkey_patches/win32/registry.rb for consistency. Doing so here is outside the scope of this PR.)

@mcquin
Copy link
Contributor Author

mcquin commented Sep 3, 2015

Most, if not all, of these spec failures are related to a bad chef-zero gem. I will rebase and re-run tests once the issue is resolved.

Please review @chef/client-windows

@@ -0,0 +1,31 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have file header

@chefsalim
Copy link
Contributor

Looks good! 👍

@adamedx adamedx closed this Sep 4, 2015
@adamedx adamedx reopened this Sep 4, 2015
@adamedx adamedx closed this Sep 4, 2015
@mcquin mcquin deleted the mcquin/monkeypatch-win32-registry-delete branch September 4, 2015 16:36
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants