Monkeypatch Win32::Registry methods delete_key, delete_value #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 3, 2015 11:18
|
not sure why it says appveyor is pending, it completed successfully |
|
@adamedx i've added you as an admin to appveyor |
|
Well, AppVeyor still says its running (it's been hours), but the output shows that it passed. So this should be safe to merge @mcquin. |
|
I need one more review and +1 from @chef/client-windows before I can merge. |
|
👍 |
|
👍 |
mcquin
added a commit
that referenced
this pull request
Sep 4, 2015
…delete Monkeypatch Win32::Registry methods delete_key, delete_value
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creation of #3870 for @mcquin because I couldn't force AppVeyor to re-run.
(Note: Once this is merged, I will move the Win32::Registry#write monkeypatch into
lib/chef/monkey_patches/win32/registry.rbfor consistency. Doing so here is outside the scope of this PR.)