Fix cookbook installation from supermarket on windows

[MichaelPereira]

• Fixes https://tickets.opscode.com/browse/CHEF-3394 by adding the --force-local option to tar
• Might fix knife cookbook site install fails on Windows in directories with spaces #1753 with the added double quotes

Successfully ran the unit tests in spec/unit/knife/cookbook_site_install_spec.rb with the change.

Proof of the fix:

[thommay]

👍 @chef/client-windows

[lamont-granquist]

👍

[smurawski]

👍

[danielsdeleo]

I think this will break BSD tar (Mac and probably *BSD):

tar zxvf apt-2.4.0.tgz --force-local
tar: Option --force-local is not supported
Usage:
  List:    tar -tf <archive-filename>
  Extract: tar -xf <archive-filename>
  Create:  tar -cf <archive-filename> [filenames...]
  Help:    tar --help

Edit: I ran this on Mac OS 10.11. Also:

$ which tar
/usr/bin/tar

[danielsdeleo]

Unless this only runs on windows or I'm missing something?

[MichaelPereira]

@danielsdeleo You're right, it doesn't run on Windows only. The commit needs to be refactored to add the --force-local parameter only for Windows. I will try to look around the code base to see how it's done.

[MichaelPereira]

I verified that 48f7688 works on Windows on my local machine:

PS U:\.chef\cookbooks> knife cookbook site install chocolatey
WARNING: No knife configuration file found
Installing chocolatey to U:/.chef/cookbooks
Checking out the master branch.
Creating pristine copy branch chef-vendor-chocolatey
Downloading chocolatey from the cookbooks site at version 0.4.0 to U:/.chef/cookbooks/chocolatey.tar.gz
Cookbook saved: U:/.chef/cookbooks/chocolatey.tar.gz
Removing pre-existing version.
Uncompressing chocolatey version 0.4.0.
removing downloaded tarball
1 files updated, committing changes
Creating tag cookbook-site-imported-chocolatey-0.4.0
Checking out the master branch.
Updating d514eec..170e3e2
Fast-forward
 chocolatey/CHANGELOG.md                    |  11 +++
 chocolatey/README.md                       |  79 +++++++++++++++++
 chocolatey/attributes/default.rb           |   4 +
 chocolatey/libraries/chocolatey_helpers.rb |  24 ++++++
 chocolatey/metadata.json                   |   1 +
 chocolatey/providers/default.rb            | 134 +++++++++++++++++++++++++++++
 chocolatey/recipes/default.rb              |  74 ++++++++++++++++
 chocolatey/resources/default.rb            |  14 +++
 8 files changed, 341 insertions(+)
 create mode 100644 chocolatey/CHANGELOG.md
 create mode 100644 chocolatey/README.md
 create mode 100644 chocolatey/attributes/default.rb
 create mode 100644 chocolatey/libraries/chocolatey_helpers.rb
 create mode 100644 chocolatey/metadata.json
 create mode 100644 chocolatey/providers/default.rb
 create mode 100644 chocolatey/recipes/default.rb
 create mode 100644 chocolatey/resources/default.rb
Cookbook chocolatey version 0.4.0 successfully installed

[danielsdeleo]

LGTM now. 👍

[thommay]

thanks @danielsdeleo, good catch!