Lcg/merges #4105
Merged
Lcg/merges #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix unit test cases. * Ignore temporary spec testing files.
ENV['HOME'] to not be set to root's home folder.
Fixes #3679 Reasoning: The definition of "healthy" is overloaded in the old form (--hide-healthy) to be "a host that has run chef". The code makes no check to determine if the chef run was successful, so it has the capability to provide false positives for "health". Just because a node object was saved with ohai_time set doesn't mean the Chef run was successful. There are exception handlers like lastrun that intentionally save the node object on exception. The previous 1 hour hardcoded time was totally arbitrary. Perhaps "healthy" to others means "nodes that have run chef in the last 4 hours" (or 30 minutes, or 3 days...).
Deprecates -H/--hide-healthy instead of removing it.
…declared sensitive
…ontext Setting these values in Chef::Config is being deprecated in favor of using the knife config directly. #3946
…we get a superclass mismatch error
- Fixes https://tickets.opscode.com/browse/CHEF-3394 by adding the `--force-local` option to tar - Might fix #1753 with the added double quotes Proof of the fix: 
just output the abs path
The deploy resource attempts to change the owner of all files in the deploy directory, but it breaks when files are removed during the process. This is because FileUtils::chown_R gets a list of the files and then walks through and updates them, and if that takes any time at all then files may be deleted during the process. When this happens, the deploy will fail with Errno::ENOENT. chown_R takes an options hash with :force as one of the available options, and the only thing it does is stop errors from being raised under these circumstances.
lamont-granquist
force-pushed
the
lcg/merges
branch
from
f1ee0f4
to
7851615
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of outstanding ready-to-merge PRs
closes #3990
closes #3986
closes #3973
closes #3968
closes #3941
closes #3911
closes #3901
closes #3900
closes #3864
closes #3858
closes #3834
closes #3776
closes #3650
closes #3633
closes #3530
closes #3529