Add optional integer argument for --daemonize option

[jrunning]

The --daemonize option takes an optional integer argument for the number of seconds to wait before the first daemonized run.

Closes #3305

[chefsalim]

Will this have backward compatibility implications and break existing scripts?

[tyler-ball]

The brackets around WAIT mean it is an optional argument and the proc below makes it retain the backwards compatible behavior if it is not present

[lamont-granquist]

I'm not sure this addresses #3305 though does it? The problem there is that if you have a non-zero splay and/or interval that you'll always sleep-before-running and this is the behavior that those users do not want to have at all -- they still want splay/interval options, but when present, they want the first run to be immediate and then for the chef-client to sleep afterwards. So a '--sleep-after-run' kind of flag to shift the interval/splay sleeps to the end of the loop.

[jrunning]

@lamont-granquist Unless I'm misunderstanding, this addresses the issue. If they pass --daemonize 0 then the first run will happen immediately, followed by the first sleep.

[lamont-granquist]

Ah okay, so i think the problem here is that you're missing all the exception decoration that we normally do around the chef-client run:

https://github.com/chef/chef/blob/jr/daemonize-immediate-run/lib/chef/application/client.rb#L457-L467

I think when you're sleeping you also need to have the sleep wrapped around with this logic or i suspect there's some edge conditions you might break:

https://github.com/chef/chef/blob/jr/daemonize-immediate-run/lib/chef/application/client.rb#L446-L453

[jrunning]

@lamont-granquist Okay, that makes sense to me. Thanks!

[jrunning]

@lamont-granquist Updated re: your comments; please let me know if you have any other feedback.

[tyler-ball]

👍

[lamont-granquist]

👍