add create and delete actions for windows_service #6595
Conversation
jasonwbarnett
force-pushed
the
feature/add-action_create-to-windows_service
branch
from
c045e58
to
97415ff
Compare
|
Thanks @jasonwbarnett, looks like you've put some work and thought into this. Appveyor is still broken here, but you'll see on Travis that Please look at adding unit and functional test coverage for the new actions. There are some changes to existing functionality here so fixing up functional tests first could help ensure we don't have regressions. And take a look at RFC082 regarding deprecating functionality. |
|
@btm I wanted to submit it to get feedback sooner, rather than later. I'll be sure to update functional test and add new unit/functional tests. There are a ton of constants in the win32-service gem. Does it make sense to copy those constants into the chef code base to eliminate the dependency across all operating systems? I'm looking for a little guidance here. |
jasonwbarnett
force-pushed
the
feature/add-action_create-to-windows_service
branch
from
97415ff
to
6c0e079
Compare
|
If you're going to use most of the constants, I'd probably copy the file in and copy the license and copyright in it. I'll check internally if we're okay with that license-wise. |
|
Yeah, we'd be okay with copying that constants file to Chef in regards to licensing. |
jasonwbarnett
force-pushed
the
feature/add-action_create-to-windows_service
branch
2 times, most recently
from
5ac27a4
to
b1b8894
Compare
…esource.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the
best of my knowledge, is covered under an appropriate open
source license and I have the right under that license to
submit that work with modifications, whether created in whole
or in part by me, under the same open source license (unless
I am permitted to submit under a different license), as
Indicated in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including
all personal information I submit with it, including my
sign-off) is maintained indefinitely and may be redistributed
consistent with this project or the open source license(s)
involved.
Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
|
Thanks for this great addition! |
|
So this needed a bunch of rspec work to fix travis + appveyor, things got very angry + red |
|
I’ll try to fix this up at some point. I just haven’t had time to finish this work fully. |
|
ok- starting to work on this now. I'll let you know when I have a solid suite of tests covering new functionality + existing tests working :) |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Description
adds
:create,:delete, and:configureactions to thewindows_serviceresource.Issues Resolved
Check List