Convert more set_or_returns to proper properties #6950
Conversation
Just modernizing our resources so we can start to add descriptions to them for the documentation Signed-off-by: Tim Smith <tsmith@chef.io>
| @@ -18,6 +18,7 @@ | |||
| # | |||
|
|
|||
| require "chef/resource" | |||
| require "chef/provider/cron" # do not remove. we actually need this below | |||
There was a problem hiding this comment.
We have a pile of cron constants in the provider
| ) | ||
| end | ||
|
|
||
| property :time, Symbol, equal_to: Chef::Provider::Cron::SPECIAL_TIME_VALUES |
There was a problem hiding this comment.
Technically we didn't restrict this to a symbol, but we expected it to be a symbol in the equal_to so this is the same
| ) | ||
| end | ||
| property :append, [ TrueClass, FalseClass ], default: false | ||
| property :system, [ TrueClass, FalseClass ], default: false |
There was a problem hiding this comment.
This lacked a default before, but it seems like the default was in fact false
| identity_attr :target_file | ||
|
|
||
| state_attrs :to, :owner, :group | ||
| state_attrs :owner # required since it's not a property below |
There was a problem hiding this comment.
This comes from Chef::Mixin::Securable which doesn't use properties so no state set
| end | ||
| property :target_file, String, name_property: true, identity: true | ||
| property :to, String | ||
| property :link_type, [String, Symbol], coerce: proc { |arg| arg.kind_of?(String) ? arg.to_sym : arg }, equal_to: [ :symbolic, :hard ], default: :symbolic |
There was a problem hiding this comment.
This had no type before, but it could be string or symbol so lets enforce that now
| property :target_file, String, name_property: true, identity: true | ||
| property :to, String | ||
| property :link_type, [String, Symbol], coerce: proc { |arg| arg.kind_of?(String) ? arg.to_sym : arg }, equal_to: [ :symbolic, :hard ], default: :symbolic | ||
| property :group, [String, Integer], regex: [Chef::Config[:group_valid_regex]] |
There was a problem hiding this comment.
group/user had no type before, but our spec checks integers so clearly those should be here
|
genuine red though: https://travis-ci.org/chef/chef/jobs/349650692#L1668 |
We're not longer initializing user to nil and instead we're letting property handle it. This user => nil statement isn't the actual test here, but was just a workaround for the funky behavior. Signed-off-by: Tim Smith <tsmith@chef.io>
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Just modernizing our resources so we can start to add descriptions to them for the documentation
Signed-off-by: Tim Smith tsmith@chef.io