Use some unique task names for windows_task functional tests #7267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2008r2 tester has been failing with an error like:
```
1) Chef::Resource::WindowsTask action :enable enables the disabled task
Failure/Error: expect(current_resource.task.status).to eq("not scheduled")
expected: "not scheduled"
got: "running"
(compared using ==)
# ./spec/functional/resource/windows_task_spec.rb:1481:in `block (3 levels) in <top (required)>'
```
This has only been happening on the enable and disable tests and appears to be a timing issue. This change gives thoses tests unique names and changes the default name to not be 'chef-client' which is more likely to collide with another test.
This change has passed chef-test on jenkins in an ad-hoc test.
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
tas50
approved these changes
May 16, 2018
stuartpreston
approved these changes
May 16, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2008r2 tester has been failing with an error like:
This has only been happening on the enable and disable tests and appears to be a timing issue. This change gives thoses tests unique names and changes the default name to not be 'chef-client' which is more likely to collide with another test.
This change has passed chef-test on jenkins in an ad-hoc test.