Added armv6l and armv7l to arm? and armhf? helpers #9887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armv6l is Raspberry Pi 1/Zero armv7l is Raspberry Pi 2,3,4 Tested with Raspbian 10, Debian 10, Centos 7 Signed-off-by: Matt Ray <github@mattray.dev>
|
Thanks @mattray our arm expert |
phiggins
reviewed
May 20, 2020
| let(:arch) { "armhf" } | ||
|
|
||
| arch_reports_true_for(:armhf?, :_32_bit?, :arm?) | ||
| end |
There was a problem hiding this comment.
I suspect these tests should have let(:arch) { "armv6l" }, etc.
There was a problem hiding this comment.
I opened #9892 to fix the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
armv6l is Raspberry Pi 1/Zero
armv7l is Raspberry Pi 2,3,4 BeagleBone Black
Tested with Raspbian 10, Debian 10, Centos 7
This support was present in chef-sugar.
Signed-off-by: Matt Ray github@mattray.dev