Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests: stop using alpine iso #379

Merged
merged 1 commit into from Jan 21, 2016
Merged

Conversation

srenatus
Copy link
Contributor

empty.iso is 348K. Makes integration tests a little faster by not downloading the alpine iso (~80M).

@srenatus srenatus added Type: Bug Feature not working as expected Type: Enhancement Improves an existing feature labels Jan 21, 2016
@chris-rock
Copy link
Contributor

@srenatus great idea, can you automate the creation of the iso as well?

@chris-rock chris-rock removed the Type: Bug Feature not working as expected label Jan 21, 2016
@srenatus
Copy link
Contributor Author

@chris-rock uhm... we could, it just takes package 'genisofs' and an execute, but should we? I'd say it's ok to include this fixture. (We didn't create the alpine image either.)

@chris-rock
Copy link
Contributor

Thanks @srenatus Just missed that the iso is included. Awesome improvement

chris-rock added a commit that referenced this pull request Jan 21, 2016
integration tests: stop using alpine iso
@chris-rock chris-rock merged commit a5ed04d into master Jan 21, 2016
@chris-rock chris-rock deleted the sr/use-empty-iso branch January 21, 2016 10:04
@chris-rock chris-rock added this to the 0.9.10 milestone Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants