-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory fix, new feature,... #21
Open
manusfreedom
wants to merge
20
commits into
chef:main
Choose a base branch
from
manusfreedom:ffi2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very useful to get the last event log. Needed in new input logstash plugin.
If treat mass eventlog, memoryleak visible. Remove registry FFI call and use win32/registry ti fix memory leak. Some optimization on memory usage and buffer (I think we don't need to reset/renew pointer, because it is a pointer).
…o ffi2 Conflicts: lib/win32/eventlog.rb
Better file description management: ignore empty file path Remove null byte in file path (some registry have bad entry) Fix miss variable in param_exe FormatMessage Fix buf is not a string in param_exe FormatMessage Fix bad parsing to build max_insert (can be memory leak in some case)
# Conflicts: # lib/win32/eventlog.rb
Add EventLog binary data support Add missing registry close key Add constants Fix possible error during FreeLibrary(hmodule) Fix previous commit misplaced memory free
Use win32/registry when add event Better use of win32/registry when get event description
Dirty hack to access remote registry using Win32::Registry
…work for GC) Use correct variable (local instead of direct FFI constants) Fix null detection (possible NPE) Username now include domain name Fix string encoding for description and insertstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.