Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ChefSpec's coverage reporting. #891

Merged
merged 2 commits into from Mar 6, 2018

Conversation

coderanger
Copy link
Contributor

So people are aware they shouldn't use it.

@tas50 tas50 merged commit 276878a into chefspec:master Mar 6, 2018
@tas50
Copy link
Contributor

tas50 commented Mar 6, 2018

YES!

@jason-riddle
Copy link

Ok, but what should be used instead?

@coderanger
Copy link
Contributor Author

@jason-riddle Nothing, there is no replacement.

@coderanger coderanger deleted the deprecate-coverage branch March 22, 2018 06:37
@iancward
Copy link
Contributor

If the intent is to deprecate code coverage, you might want to update the description of the repo:
image

@jamietanna
Copy link

Out of interest, would there be any appetite for re-maintaining it? Or is it less used, so should be pushed out to a separate tool?

@tas50
Copy link
Contributor

tas50 commented Jun 19, 2018

It's not a matter of deprecating it so we don't have to maintain the code. When using the coverage reporting functionality people tend to right bad specs. You should not be chasing 100% spec coverage in Chef cookbooks. It doesn't make sense and it gives you a false sense of security. You should be testing the portion of your cookbook with logic. If that's 10% of the total cookbook then you only need/want 10% coverage.

@daxgames
Copy link

But what about people that write GOOD specs that evaluate logic like guards and differing attribute values that cause resource collections to have different contents? In this case I think the coverage reports are very valuable and the fact there is no replacement is not good for those that do use it and do it right.

jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Sep 14, 2021
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Sep 14, 2021
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Sep 14, 2021
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Sep 16, 2021
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Sep 21, 2021
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Oct 9, 2021
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Jan 23, 2022
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Jan 23, 2022
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Jan 23, 2022
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Feb 16, 2022
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
@blackknight36
Copy link

IMO this is an essential feature and should not be removed until there is an alternative available. Yes, writing unit tests is annoying but it is also essential in ensuring that your recipes work as expected.

jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Mar 6, 2022
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Mar 28, 2022
The idea isn’t to cover everything, it’s to cover everything that has logic,
such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Mar 28, 2022
The idea isn’t to cover everything, it’s to cover everything that has
logic, such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Mar 28, 2022
The idea isn’t to cover everything, it’s to cover everything that has
logic, such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Mar 31, 2022
The idea isn’t to cover everything, it’s to cover everything that has
logic, such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Mar 31, 2022
The idea isn’t to cover everything, it’s to cover everything that has
logic, such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Jul 14, 2022
The idea isn’t to cover everything, it’s to cover everything that has
logic, such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Aug 25, 2022
The idea isn’t to cover everything, it’s to cover everything that has
logic, such as libraries.

See chefspec/chefspec#891
jeffbyrnes added a commit to jeffbyrnes/chef-datadog that referenced this pull request Oct 12, 2022
The idea isn’t to cover everything, it’s to cover everything that has
logic, such as libraries.

See chefspec/chefspec#891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants