-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fauxhai lacks the empty virtualization hash #206
Comments
Hrm - was that always true or is that a recent addition to Ohai? |
7.20 so chef 11.14 |
Ah okay. Fauxhai exists pre-that. We could probably do a quick thing like: Dir.glob("**/*.json).each do |file|
x = JSON.parse(File.read(file))
x["virtualization"] = {}
File.open(file, "w") { |f| f.write(JSON.generate(x) }
end |
Yes please. It's currently causing chefspec tests to fail, if the latest build-essential cookbook is used. |
Merged to master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A non-virtualized Chef system still includes the empty hash. A lot of the time people do checks like:
unless node['virtualization']['systems']['docker'] && node['virtualization']['systems']['docker'] == 'guest'
This will fail on fauxhai with a nil error. node['virtualization']['systems'] should exist which would prevent those failures.
The text was updated successfully, but these errors were encountered: