Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Recording rule for contact GROUP #536

Closed
StanTody opened this issue Apr 30, 2024 · 1 comment · Fixed by #606
Closed

[enhancement] Recording rule for contact GROUP #536

StanTody opened this issue Apr 30, 2024 · 1 comment · Fixed by #606
Assignees
@chenxiaolong
Labels
enhancement New feature or request

Comments

@StanTody
Copy link

StanTody commented Apr 30, 2024 •
edited
Loading

Hi, dear friend !

I like your app very much - it is the only one, I found working on my device (Samsung S23, A14).

I have a suggestion for an enhancement - it will be great if rules can be set for contact GROUPS too. In that way number of rules may decrease A LOT.

Thanks in advance and easy coding !
@StanTody StanTody changed the title Recording rule for contact GROUP [enhancement] Recording rule for contact GROUP Apr 30, 2024
@chenxiaolong
Copy link
Owner

Glad you like BCR!

I think this is a good idea. I currently don't have time to implement it, but will likely do so in the future.

@chenxiaolong chenxiaolong self-assigned this Apr 30, 2024
@chenxiaolong chenxiaolong added the enhancement New feature or request label Apr 30, 2024
chenxiaolong added a commit that referenced this issue Sep 22, 2024
@chenxiaolong
Add support for using contact groups in record rules
723dd31 
This is unfortunately a relatively big change because unlike single
contacts, Android does not provide a standard intent for apps to select
a contact group. We have to implement our own contact group picker UI.

Following our current convention, the most specific rule wins as a side
effect of how rules are sorted. If a call matches both a contact and a
contact group, the contact rule has higher precedence.

Fixes: #536

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
@chenxiaolong chenxiaolong mentioned this issue Sep 22, 2024
Merged
chenxiaolong added a commit that referenced this issue Sep 22, 2024
@chenxiaolong
Add support for using contact groups in record rules
efd4caa 
This is unfortunately a relatively big change because unlike single
contacts, Android does not provide a standard intent for apps to select
a contact group. We have to implement our own contact group picker UI.

Following our current convention, the most specific rule wins as a side
effect of how rules are sorted. If a call matches both a contact and a
contact group, the contact rule has higher precedence.

Fixes: #536

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong added a commit that referenced this issue Sep 22, 2024
@chenxiaolong
Add support for using contact groups in record rules
575d29f 
This is unfortunately a relatively big change because unlike single
contacts, Android does not provide a standard intent for apps to select
a contact group. We have to implement our own contact group picker UI.

Following our current convention, the most specific rule wins as a side
effect of how rules are sorted. If a call matches both a contact and a
contact group, the contact rule has higher precedence.

Fixes: #536

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for using contact groups in record rules chenxiaolong/BCR
2 participants
@chenxiaolong @StanTody