array_shift causes arguments following a zero argument to be omitted

[robincafolla]

Problem

Use of the return result from array_shift as the condition of the loop here:

php-cli-args/src/CliArgs/CliArgs.php

Line 293 in fddcd44

while ($arg = array_shift($argv)) {

Causes any arguments after a zero argument to be omitted. This is because the zero value is evaluated as false.

Test case

//test.php
$cliConfig = [
  'a' => [
    'help' => 'A',
  ],
  'b' => [
    'help' => 'B'
  ],
  'c' => [
    'help' => 'C'
  ],
];

$cliArgs = new CliArgs($cliConfig);
var_dump($cliArgs->getArguments());

Running the above script with php test.php --a 1 --b 0 --c 1 will result in the following output:

array(3) {
  [0] =>  string(13) "/tmp/test.php"
  'a' =>  string(1) "1"
  'b' =>  NULL
}

The value for b is incorrect, and c is missing entirely.

Recommendation

Replace

while ($arg = array_shift($argv)) {

with

while (count($argv) > 0) {
  $arg = array_shift($argv);

[robincafolla]

I can open a PR to fix this if it suits @cheprasov

[cheprasov]

Hi @robincafolla sorry for the delay with the answer. Thanks a lot for the bug, I will try to fix it soon :)

[robincafolla]

No worries, I know how it is.