fix: Check API responses are provided correctly in Swagger document [DEV-3133] #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because this custom method is written incorrectly and doesn't allow to show swagger.json in SwaggerUI.
of boolean type in `/did/deactivate/{did}` endpoint.
requestResourcePayload in `/resource/create/{did}`.
ankurdotb
reviewed
Sep 5, 2023
Eengineer1
reviewed
Sep 5, 2023
abdulla-ashurov
commented
Sep 7, 2023
There was a problem hiding this comment.
After that commit changes in develop branch, currently updateUnecreptedStatusList2021 method from did-provider-cheqd returns resource and resourceMetadata for that reason I removedd9f82ce my manualy line of code where I try to get these are fields using DID Resolver after updateStatusList operation.
@ankurdotb, @Eengineer1 Now, PR is ready review! ✅
ankurdotb
approved these changes
Sep 7, 2023
cheqd-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
## [2.9.2-develop.2](2.9.2-develop.1...2.9.2-develop.2) (2023-09-07) ### Bug Fixes * Check API responses are provided correctly in Swagger document [DEV-3133] ([#359](#359)) ([5b13ffa](5b13ffa))
|
🎉 This PR is included in version 2.9.2-develop.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
cheqd-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
## [2.9.2](2.9.1...2.9.2) (2023-09-12) ### Bug Fixes * Add DID deactivation check for credential issuing [DEV-3136] ([#345](#345)) ([023bba1](023bba1)) * Check API responses are provided correctly in Swagger document [DEV-3133] ([#359](#359)) ([5b13ffa](5b13ffa)) * Enable updated state explicitly ([c3d9170](c3d9170))
|
🎉 This PR is included in version 2.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
booleantoDeactivatedDidResolutiontype in/did/deactivate/{did}endpoint.RequestResourcePayloadto an existingResourceMetadatain/resource/create/{did}endpoint./credential-status/update/unencryptedto similar like in/credential-status/create/unencryptedendpoint.Account,Key,DID,Resources,Credential,Presentation,Credential-Status.