Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subscription update request body schema #547

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

benyam7
Copy link
Contributor

@benyam7 benyam7 commented Jun 24, 2024

This PR's change might seem insignificant, but it actually has an impact. We have a request body validation check at the update subscritpion, that we're performing here. You might wonder why we don't just change the request body validation check to returnUrl instead. While I could do that, I chose to keep things consistent with (successURL, cancelURL). And this is why the FE is throwing an error when trying to update a plan.

@benyam7 benyam7 self-assigned this Jun 24, 2024
@ankurdotb ankurdotb merged commit c0a8879 into develop Jun 24, 2024
14 checks passed
@ankurdotb ankurdotb deleted the fix-SubscriptionUpdateRequestBody branch June 24, 2024 10:49
cheqd-bot bot pushed a commit that referenced this pull request Jun 24, 2024
## [2.20.3-develop.3](2.20.3-develop.2...2.20.3-develop.3) (2024-06-24)

### Bug Fixes

* subscription update request body schema ([#547](#547)) ([c0a8879](c0a8879))
@cheqd-bot
Copy link

cheqd-bot bot commented Jun 24, 2024

🎉 This PR is included in version 2.20.3-develop.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Jul 3, 2024
## [2.21.0](2.20.2...2.21.0) (2024-07-03)

### Features

* Add a basic form for pagination for Stripe Product list endpoint ([#549](#549)) ([e8439e5](e8439e5))
* cheqd Studio rebranding [DEV-4010] ([#550](#550)) ([bb58b44](bb58b44))

### Bug Fixes

* Fix test payloads ([#553](#553)) ([78b4b84](78b4b84))
* Incorrect customer/Stripe details stored in DB [DEV-4005] ([#543](#543)) ([e6dd226](e6dd226))
* Manage user plan intents [DEV-4024] ([#545](#545)) ([4563b83](4563b83))
* Product list (Stripe) OpenAPI schema ([#554](#554)) ([81ff8ce](81ff8ce))
* Stripe account submitter [DEV-4042] ([#548](#548)) ([198c9da](198c9da))
* subscription update request body schema ([#547](#547)) ([c0a8879](c0a8879))
@cheqd-bot
Copy link

cheqd-bot bot commented Jul 3, 2024

🎉 This PR is included in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Jul 3, 2024
ankurdotb pushed a commit that referenced this pull request Jul 5, 2024
* chore: Update package lock

* chore(release): 2.21.0 [skip ci]

## [2.21.0](2.20.2...2.21.0) (2024-07-03)

### Features

* Add a basic form for pagination for Stripe Product list endpoint ([#549](#549)) ([e8439e5](e8439e5))
* cheqd Studio rebranding [DEV-4010] ([#550](#550)) ([bb58b44](bb58b44))

### Bug Fixes

* Fix test payloads ([#553](#553)) ([78b4b84](78b4b84))
* Incorrect customer/Stripe details stored in DB [DEV-4005] ([#543](#543)) ([e6dd226](e6dd226))
* Manage user plan intents [DEV-4024] ([#545](#545)) ([4563b83](4563b83))
* Product list (Stripe) OpenAPI schema ([#554](#554)) ([81ff8ce](81ff8ce))
* Stripe account submitter [DEV-4042] ([#548](#548)) ([198c9da](198c9da))
* subscription update request body schema ([#547](#547)) ([c0a8879](c0a8879))

* chore: Change npm registry package name

---------

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
cheqd-bot bot pushed a commit that referenced this pull request Jul 5, 2024
## [3.0.0-develop.1](2.21.0-develop.3...3.0.0-develop.1) (2024-07-05)

### ⚠ BREAKING CHANGES

* Change npm package name [DEV-4066] (#558)

### Features

* Change npm package name [DEV-4066] ([#558](#558)) ([5c032f5](5c032f5)), closes [#549](#549) [#550](#550) [#553](#553) [#543](#543) [#545](#545) [#554](#554) [#548](#548) [#547](#547)
cheqd-bot bot pushed a commit that referenced this pull request Jul 15, 2024
## [3.0.0](2.21.0...3.0.0) (2024-07-15)

### ⚠ BREAKING CHANGES

* Change npm package name [DEV-4066] (#558)

### Features

* Change npm package name [DEV-4066] ([#558](#558)) ([5c032f5](5c032f5)), closes [#549](#549) [#550](#550) [#553](#553) [#543](#543) [#545](#545) [#554](#554) [#548](#548) [#547](#547)

### Bug Fixes

* switch to x-api-key header authentication [DEV-4062] ([#556](#556)) ([01e6ab8](01e6ab8)), closes [#557](#557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants