Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stripe account submitter [DEV-4042] #548

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Conversation

benyam7
Copy link
Contributor

@benyam7 benyam7 commented Jun 26, 2024

This PR resolves an issue with the conditional check that initiates the creation of a Stripe account. Previously, the if statement was returning false, which led to failures in creating a Stripe account for a user and in populating the paymentProviderID in the database. Resulting failure in the Account Bootstrap webhook.

@benyam7 benyam7 requested a review from ankurdotb June 26, 2024 08:28
@benyam7 benyam7 self-assigned this Jun 26, 2024
@benyam7
Copy link
Contributor Author

benyam7 commented Jun 26, 2024

I am closing this pull request now and will create a new one because the CI is not recognizing an update to a github actions secret made after the pull request was created. [Ignore this wasn't the issue, the issue was "test@cheqd.io" missing roles.

@benyam7 benyam7 closed this Jun 26, 2024
@benyam7 benyam7 reopened this Jun 26, 2024
@benyam7 benyam7 requested a review from jay-dee7 June 27, 2024 08:17
@benyam7 benyam7 changed the title fix: stripe account creator fix: stripe account submitter [DEV-4042] Jun 27, 2024
@ankurdotb
Copy link
Contributor

Task linked: DEV-4042 fix: Stripe account submitter (BE)

@benyam7 benyam7 changed the title fix: stripe account submitter [DEV-4042] fix: Stripe account submitter [DEV-4042] Jun 27, 2024
@benyam7 benyam7 requested a review from Eengineer1 June 27, 2024 08:24
@benyam7 benyam7 marked this pull request as ready for review June 27, 2024 08:25
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Approved.

@Eengineer1 Eengineer1 merged commit 198c9da into develop Jun 27, 2024
13 of 14 checks passed
@Eengineer1 Eengineer1 deleted the fix-account-bootstrap branch June 27, 2024 12:05
cheqd-bot bot pushed a commit that referenced this pull request Jul 1, 2024
## [2.20.3-develop.4](2.20.3-develop.3...2.20.3-develop.4) (2024-07-01)

### Bug Fixes

* Fix test payloads ([#553](#553)) ([78b4b84](78b4b84))
* Stripe account submitter [DEV-4042] ([#548](#548)) ([198c9da](198c9da))
@cheqd-bot
Copy link

cheqd-bot bot commented Jul 1, 2024

🎉 This PR is included in version 2.20.3-develop.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Jul 3, 2024
## [2.21.0](2.20.2...2.21.0) (2024-07-03)

### Features

* Add a basic form for pagination for Stripe Product list endpoint ([#549](#549)) ([e8439e5](e8439e5))
* cheqd Studio rebranding [DEV-4010] ([#550](#550)) ([bb58b44](bb58b44))

### Bug Fixes

* Fix test payloads ([#553](#553)) ([78b4b84](78b4b84))
* Incorrect customer/Stripe details stored in DB [DEV-4005] ([#543](#543)) ([e6dd226](e6dd226))
* Manage user plan intents [DEV-4024] ([#545](#545)) ([4563b83](4563b83))
* Product list (Stripe) OpenAPI schema ([#554](#554)) ([81ff8ce](81ff8ce))
* Stripe account submitter [DEV-4042] ([#548](#548)) ([198c9da](198c9da))
* subscription update request body schema ([#547](#547)) ([c0a8879](c0a8879))
@cheqd-bot
Copy link

cheqd-bot bot commented Jul 3, 2024

🎉 This PR is included in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Jul 3, 2024
ankurdotb pushed a commit that referenced this pull request Jul 5, 2024
* chore: Update package lock

* chore(release): 2.21.0 [skip ci]

## [2.21.0](2.20.2...2.21.0) (2024-07-03)

### Features

* Add a basic form for pagination for Stripe Product list endpoint ([#549](#549)) ([e8439e5](e8439e5))
* cheqd Studio rebranding [DEV-4010] ([#550](#550)) ([bb58b44](bb58b44))

### Bug Fixes

* Fix test payloads ([#553](#553)) ([78b4b84](78b4b84))
* Incorrect customer/Stripe details stored in DB [DEV-4005] ([#543](#543)) ([e6dd226](e6dd226))
* Manage user plan intents [DEV-4024] ([#545](#545)) ([4563b83](4563b83))
* Product list (Stripe) OpenAPI schema ([#554](#554)) ([81ff8ce](81ff8ce))
* Stripe account submitter [DEV-4042] ([#548](#548)) ([198c9da](198c9da))
* subscription update request body schema ([#547](#547)) ([c0a8879](c0a8879))

* chore: Change npm registry package name

---------

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
cheqd-bot bot pushed a commit that referenced this pull request Jul 5, 2024
## [3.0.0-develop.1](2.21.0-develop.3...3.0.0-develop.1) (2024-07-05)

### ⚠ BREAKING CHANGES

* Change npm package name [DEV-4066] (#558)

### Features

* Change npm package name [DEV-4066] ([#558](#558)) ([5c032f5](5c032f5)), closes [#549](#549) [#550](#550) [#553](#553) [#543](#543) [#545](#545) [#554](#554) [#548](#548) [#547](#547)
cheqd-bot bot pushed a commit that referenced this pull request Jul 15, 2024
## [3.0.0](2.21.0...3.0.0) (2024-07-15)

### ⚠ BREAKING CHANGES

* Change npm package name [DEV-4066] (#558)

### Features

* Change npm package name [DEV-4066] ([#558](#558)) ([5c032f5](5c032f5)), closes [#549](#549) [#550](#550) [#553](#553) [#543](#543) [#545](#545) [#554](#554) [#548](#548) [#547](#547)

### Bug Fixes

* switch to x-api-key header authentication [DEV-4062] ([#556](#556)) ([01e6ab8](01e6ab8)), closes [#557](#557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants