Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ascii no longer allowed in URIs on Python 2 only #55

Closed
jaraco opened this issue Nov 15, 2017 · 2 comments
Closed

Non-ascii no longer allowed in URIs on Python 2 only #55

jaraco opened this issue Nov 15, 2017 · 2 comments
Labels
bug Something is broken invalid This is irrelevant

Comments

@jaraco
Copy link
Member

jaraco commented Nov 15, 2017

  • I'm submitting a ...
    [X] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository

  • What is the current behavior?

Since the commit in 51c004a, committed in #39 and released as 5.8.0, cheroot no longer accepts non-ascii in the URI. Prior versions of CherryPy allowed this (under some conditions) and one of our key applications relies on that behavior.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a screenshots and logs of the problem. If you can, show us your code.

I'll put together a test in the suite.

  • What is the expected behavior?

cheroot should provide some mechanism to accept non-ascii in URIs.

  • What is the motivation / use case for changing the behavior?

Existing applications still stuck on Python 2 require the ability to support these URIs.

  • Please tell us about your environment:
  • Python version: 2.7
  • Cheroot version: 5.8.3
  • CherryPy version: 11.x (if applicable)
  • OS: macOS 10.13.1
  • Browser: n/a
@webknjaz
Copy link
Member

STR? Are you talking about quoted unicode in this issue?

@jaraco
Copy link
Member Author

jaraco commented Nov 21, 2017

Upon further review, and in light of #59, there's nothing to be done here. Clients should quote non-ascii characters in their URIs.

@jaraco jaraco closed this as completed Nov 21, 2017
@jaraco jaraco added the invalid This is irrelevant label Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken invalid This is irrelevant
Projects
None yet
Development

No branches or pull requests

2 participants