Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flesh out models #6

Closed
cheshire137 opened this issue Mar 4, 2017 · 0 comments
Closed

Flesh out models #6

cheshire137 opened this issue Mar 4, 2017 · 0 comments
Assignees

Comments

@cheshire137
Copy link
Owner

cheshire137 commented Mar 4, 2017

Barebones models were added in #5. We should add reasonable validations and relations in a follow-up branch. Some fields are marked as NOT NULL in the database, so we should have presence validations on them. There should be length validations on string fields. Relations such as belongs_to :user on the Player model should be added to connect models together based on foreign keys.

Different models could be tackled in separate branches to keep pull requests easily reviewable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant