Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing functions from refactor #12

Open
chessai opened this issue Dec 6, 2018 · 8 comments
Open

missing functions from refactor #12

chessai opened this issue Dec 6, 2018 · 8 comments

Comments

@chessai
Copy link
Owner

chessai commented Dec 6, 2018

There are some functions missing after the refactor. They were simply forgotten when re-implementing the library. @GregorySchwartz brought some good ones up. If anyone notices any more, please report them here. I will be looking through and re-implementing them, taking note here.

@GregorySchwartz
Copy link

Thank you for re-adding those functions!

@GregorySchwartz
Copy link

What about diagRow, ident, getColSums, and getRowSums? Can you make a new release with these?

@GregorySchwartz
Copy link

Basically, everything from my initial pull request in the old repository that isn't in the new one:

squareSubset
ones
ident
diagCol
diagRow
getRowSums
getColSums
getSum

@chessai
Copy link
Owner Author

chessai commented Jan 11, 2019

Yes, I can get this out tomorrow.

@GregorySchwartz
Copy link

What is the status of these functions?

@chessai
Copy link
Owner Author

chessai commented Jan 21, 2019

@GregorySchwartz they exist in a branch, but I introduced a bug on that branch so it's blocked on merging. Sorry for not delivering; ive been incredibly busy. I have not forgotten about this.

@GregorySchwartz
Copy link

@chessai Is there a way to help this merge along?

@chessai
Copy link
Owner Author

chessai commented May 1, 2019

@GregorySchwartz sorry for the extreme delay. I haven't had as much time to work on features. When working on this branch I introduced a bug, which stalled me, since I was expecting this to not take very long. It might make the most sense to add these functions on a branch from the current master, rather than the branch i was working on. If you are able to work on a PR that would be very helpful in getting these functions merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants