-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a histogram panel to show the GC pause time distribution #43
Comments
If you have suggestions for how to do things better, I can try my hand at cleaning up the hack I put in place to do it - but having the distribution of pause times displayed visually alongside the other visualization really helps me see at a glance what's going on. |
Have you looked at GCHisto?
On Nov 1, 2012, at 7:49 PM, Ryan Gardner notifications@github.com wrote:
|
I've seen gchist, yes. Afaik it isn't being maintained anymore so it can't Adding a jfreechart-based histogram to gcviewer is almost trivial to do and. (If you aren't interested in putting it in the main gcviewer that's fine,
|
I meant look at GCHisto in terms of requirements. I think it's a great idea to add a histogram feature and make GCviewer more comprehensive. If JFreeChart does the job and is easy to maintain, I don't see why it's a problem. However, I'm not a GUI expert and will let the experts chime in. -Rupesh On Nov 2, 2012, at 3:57 PM, Ryan Gardner notifications@github.com wrote:
|
Oh, ok. If you look at my fork I've got something kind of working. You have to If you are on os x, I also adjusted the pom to use the bundle plugin and
|
Hi Ryan I like the idea of having a histogram of the pause time distribution in I haven't used JFreeChart yet. Do you have experience using it? It looks On my wishlist for your histogram I have the following items:
Looking forward to seeing more of your histogram! Regards, Jörg |
I haven't used JFreeChart much before, but getting those additional GC The documentation for JFreeChart does seem lacking - the stuff I've found What would be really interesting would be to have both it on its own tab - On Mon, Nov 5, 2012 at 1:16 PM, chewiebug notifications@github.com wrote:
|
Hi Ryan, I begin to understand what you would like to see in GCViewer. It might There is another issue open partial log file Regards, Jörg |
Hi Ryan It is again not what you were looking for, but maybe a step closer. I have added support for simple gc logs. Using this export format you are able to use gchisto to show you a histogram. Regards, Jörg |
Actually if you create graph histogram for real data you find it is rarely usefull. You will see many values localised around average and then some longer times. In graph you will not see much. So I suggest instead of creating graph just compute histogram as table where it is possible to set min,max and step - this can be also based on actual values so default values can be found from data. Besides count you can also compute percentage. And eventually also compute percentiles. This will be much easier as these are tabular data, no complications from graphics. Anyway as histogram data can be copy/pasted or exported then it is easy to use any graphical program to create graph histogram if desired. As this issue is pending for so long this could be step to implement it in some usefull way. It is what I am doing now - get GC times from GC Log and compute histogram to see gc pause distribution. |
Having a histogram would be very helpful.
I hacked together something quickly using JFreeChart to do this - but someone who is better with Swing could likely do it much better.
JFreeChart makes it easy to do the histogram part - you could also have it have different colors for the different kind of pause events.
https://github.com/ryangardner/GCViewer/commit/1926f74d65aa1004bce40c9441db90ce894b7f74
The text was updated successfully, but these errors were encountered: