Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnemonic sent do docker log in plain text #11

Closed
lrvick opened this issue Apr 3, 2021 · 2 comments
Closed

Mnemonic sent do docker log in plain text #11

lrvick opened this issue Apr 3, 2021 · 2 comments

Comments

@lrvick
Copy link

lrvick commented Apr 3, 2021

This container currently logs the private key mnemonic in plain text to whatever the docker system logging daemon is.

In many cases this is widely readable by monitoring systems etc.

This is a serious vulnerability.

$ docker logs chia
Chia directory /root/.chia/mainnet
Can't find private CA, creating a new one in /root/.chia/mainnet to generate TLS certificates
No keys are present in the keychain. Generate them with 'chia keys generate'

To see your keys, run 'chia keys show'
Added private key with public key fingerprint 1076947857 and mnemonic
ghost sense make design slush bulb liquid unaware home heart host charge talk type lady life renew weird test topic trust adult thumb cabbage
@jnaulty
Copy link

jnaulty commented Apr 3, 2021

I think it's caused by this: https://github.com/Chia-Network/chia-blockchain/blob/0252852bc02191892eb5f020f13aeefef5e457b6/src/cmds/keys_funcs.py#L53 (when generating a new key, it prints it to stdout)

@justinengland
Copy link
Member

this is a beta deployment. I do not recommend running this in a shared ecosystem. Treat this instance like you would a bare metal instance with these keys. I will look into making this more shared environment friendly but that is very low on priority atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants