@cache_response doesn't seem to be working with DRF 2.4

[ondrowan]

I'm getting following exception while using DRF 2.4 and Django 1.7:

Traceback (most recent call last):
  File "/usr/lib/python3.3/wsgiref/handlers.py", line 137, in run
    self.result = application(self.environ, self.start_response)
  File "/home/vagrant/.virtualenvs/project/lib/python3.3/site-packages/django/core/handlers/wsgi.py", line 187, in __call__
    response = self.get_response(request)
  File "/home/vagrant/.virtualenvs/project/lib/python3.3/site-packages/django/core/handlers/base.py", line 210, in get_response
    response._closable_objects.append(request)
AttributeError: 'Response' object has no attribute '_closable_objects'

It works alright if I downgrade to DRF 2.3 or remove @cache_response from given view.

[chibisov]

Hi @ondrowan.
I couldn't reproduce this bug. Could you show your view implementation?

I've added tests for drf==2.4.2, and don't see any problems with them for now:

• Django 1.5 https://travis-ci.org/chibisov/drf-extensions/jobs/34627990
• Django 1.7 https://travis-ci.org/chibisov/drf-extensions/jobs/34627994

[ondrowan]

I'm sorry, there's important fact I forgot to mention. First request always works ok, from 2nd on I get this exception.

I've made a test repo where you can try it out: https://github.com/ondrowan/drf-extensions-issue-32. It's just copy & pasted DRF tutorial with extensions added. Views are in urls.py and the only working resource is /users/. If you refresh it 2nd time, you get the exception. Restarting the server (obviously) fixes the issue for a single request.

[chibisov]

I've created issue in DRF repository. Will see, on which side this error should be handled.

[chibisov]

I've made a hack for fixing this issue. Please, give a feedback. If you don't have any problems I'll release new version.

[ondrowan]

It seems to be working fine now. Will let you know if it changes. Thanks for quick fix!