Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Computing normal stats is wrong #36

Closed
dagap opened this issue Jan 16, 2020 · 0 comments
Closed

[BUG]: Computing normal stats is wrong #36

dagap opened this issue Jan 16, 2020 · 0 comments

Comments

@dagap
Copy link

dagap commented Jan 16, 2020

The following code:

organized[t].append(predictions[step+t-args.prediction_window_size][args.prediction_window_size-1-step])

Should this not be simply:

organized[t].append(predictions[step+t-args.prediction_window_size][step])

Otherwise, I think it is reversing the vector.

Also, I think you should use the absolute value for computing the error vector.

@dagap dagap changed the title [BUG]: Computing normal stats iswrong [BUG]: Computing normal stats is wrong Jan 16, 2020
@dagap dagap closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant